<table><tr><td style="">sander added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15204">View Revision</a></tr></table><br /><div><div><p>Would it a good idea to split those changes that deal with the color alpha channel into a separate patch?  That would make reviewing easier, and lead to more legible git history.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15204#inline-81993">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parttest.cpp:45</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">public</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">CloseDialogHelper</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Okular</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Part</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">p</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">QDialogButtonBox</span><span style="color: #aa2211">::</span><span class="n">StandardButton</span> <span class="n">b</span><span class="p">)</span> <span style="color: #aa2211">:<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">m_part</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">p</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span> <span class="n">m_button</span><span class="p">(</span><span class="n">b</span><span class="p">),</span> <span class="n">m_clicked</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">CloseDialogHelper</span><span class="p">(</span><span class="n">QDialogButtonBox</span><span style="color: #aa2211">::</span><span class="n">StandardButton</span> <span class="n">b</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">m_button</span><span class="p">(</span><span class="n">b</span><span class="p">),</span> <span class="n">m_clicked</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this change really needed for the Typewriter tool, or is it 'just' related cleanup of the <tt style="background: #ebebeb; font-size: 13px;">CloseDialogHelper</tt> class? If the latter, can we move it into a separate patch?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15204#inline-81992">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageviewannotator.cpp:274</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">clicked</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #74777d">// safety check</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whitespace change</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15204">https://phabricator.kde.org/D15204</a></div></div><br /><div><strong>To: </strong>tobiasdeiminger<br /><strong>Cc: </strong>sander, okular-devel, ngraham, aacid<br /></div>