<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14904">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14904#313604" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14904#313604</a>, <a href="https://phabricator.kde.org/p/sander/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sander</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Thanks for the patch.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I like 'Expand whole section', too.</li>
<li class="remarkup-list-item">I don't think additional separators are necessary.</li>
<li class="remarkup-list-item">Four times the same icon looks strange to me, but I don't know what the alternatives are.</li>
</ul></div>
</blockquote>
<p>Don't have any icon?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>None of this is blocking to me. <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a> , do you object to me merging this?</p></blockquote>
<p>The braces are all in the wrong place, and <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> didn't seem to happy with the wording as far as i understand.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14904#inline-80208">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:2996</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_toc</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">TOC</span><span style="color: #aa2211">::</span><span class="n">expandRecursively</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">popup</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view-list-tree"</span><span class="p">)),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Collapse recursively"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_toc</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">TOC</span><span style="color: #aa2211">::</span><span class="n">collapseRecursively</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Would "Collapse children" instead of just "Collapse" make more sense? For some reason my brain thought this would close up until the root when i read "Collapse recursively"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14904">https://phabricator.kde.org/D14904</a></div></div><br /><div><strong>To: </strong>Lekensteyn, Okular, ngraham<br /><strong>Cc: </strong>sander, aacid, ngraham, okular-devel, Okular<br /></div>