<table><tr><td style="">sander marked 3 inline comments as done.<br />sander added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7949">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>>Unlike for CUPS printing, Qt printing prints on the entire page and does not scale to the printable area yet. This is only because it is the easiest way. I > >plan to implement a few standard scaling methods in a subsequent patch, which will only be a few additional lines of code.</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Has this been worked on? If not, there should be a hint in the tooltip.</p></blockquote>
<p>That is <a href="https://phabricator.kde.org/D7962" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D7962</a> . I put it on hold, because I didn't want to spend more time on time before knowing whether this patch here will get merged or not.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>> being able to use the Arthur backend in my daily work.<br />
I guess you don't print annotations then ;) For me, highlighter annotations are rendered opaque. Not a blocker, of course, but maybe worth to file a bug for.</p></blockquote>
<p>That is interesting. Arthur renders them correctly to a screen, but I can confirm that they are opaque when printed.<br />
Could this be a QPrinter bug? It is the same poppler backend code for screen and printer output.</p>
<p>That being said, highlighter annotations were a bit difficult to implement in Arthur, because they use a pdf<br />
feature called 'transparency groups', which maps badly to Qt.</p>
<p>I also implemented all your further suggestions. I hope I understood them correctly: not sure where you wanted the colon to be.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7949">https://phabricator.kde.org/D7949</a></div></div><br /><div><strong>To: </strong>sander, Okular<br /><strong>Cc: </strong>okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid<br /></div>