<table><tr><td style="">rkflx accepted this revision.<br />rkflx added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7949">View Revision</a></tr></table><br /><div><div><p>Thanks, accepting the Diff from my side (obviously I cannot speak for the Okular project).</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7949#290074" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D7949#290074</a>, <a href="https://phabricator.kde.org/p/sander/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sander</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>That is <a href="https://phabricator.kde.org/D7962" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D7962</a> . I put it on hold, because I didn't want to spend more time on time before knowing whether this patch here will get merged or not.</p></div>
</blockquote>
<p>Ah, I knew there was a Diff somewhere. Also, there is now <a href="https://phabricator.kde.org/D10974" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10974: Add option to ignore print margins</a>, so this probably needs some coordination. Anyway, I don't think it's mandatory to wait for that, you could just add a hint to the tooltip that QPrinter does not scale to the printable area yet.</p>
<p>BTW, if you write <a href="https://phabricator.kde.org/D7962" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D7962</a> instead of <a href="https://phabricator.kde.org/D7962" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D7962</a>, Phabricator will automatically add mentions to the review, which makes discovering things easier. Also, dependencies can be expressed with a line in the summary, e.g. <a href="https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches" class="remarkup-link" target="_blank" rel="noreferrer"><tt style="background: #ebebeb; font-size: 13px;">Depends on D7949</tt></a> (here you could use <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Edit Related Revisions</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Edit Child Revisions</span></span></span>).</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>For me, highlighter annotations are rendered opaque. Not a blocker, of course, but maybe worth to file a bug for.</p></blockquote>
<p>That is interesting. Arthur renders them correctly to a screen, but I can confirm that they are opaque when printed.<br />
Could this be a QPrinter bug? It is the same poppler backend code for screen and printer output.</p></blockquote>
<p>You are the expert here, so I guess it's up to you to fix or at least report this at the appropriate place ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7949#inline-73773">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator_pdf.cpp:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_printBackend</span><span style="color: #aa2211">-></span><span class="n">setItemData</span><span class="p">(</span><span class="n">CUPSBackend</span><span class="p">,</span> <span class="n">xi18n</span><span class="p">(</span><span style="color: #766510">"Print using the CUPS printing system.<nl/>This will convert your PDF file to PostScript first,<nl/>and then send the PostScript file to the printer."</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ToolTipRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_printBackend</span><span style="color: #aa2211">-></span><span class="n">setItemData</span><span class="p">(</span><span class="n">CUPSBackend</span><span class="p">,</span> <span class="n">xi18n</span><span class="p">(</span><span style="color: #766510">"Print using the CUPS printing system.<nl/>This will convert your PDF file to PostScript first,<nl/>and then send the PostScript file to the printer."</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">WhatsThisRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As there is no way to access <tt style="background: #ebebeb; font-size: 13px;">Qt::WhatsThisRole</tt> from the UI, perhaps the line for <tt style="background: #ebebeb; font-size: 13px;">Qt::ToolTipRole</tt> is enough?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7949">https://phabricator.kde.org/D7949</a></div></div><br /><div><strong>To: </strong>sander, Okular, rkflx<br /><strong>Cc: </strong>okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid<br /></div>