<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13484">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13484#inline-72111">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:1556</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_formsMessage</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"This document has forms of which atleast one is a signature form. Click on the buttons to interact with them."</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think atleast is not a word. Also does the user really care about this "you have a signature form", why are signature forrms more important than the rest?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13484#inline-72112">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:3571</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">message</span> <span style="color: #aa2211">=</span> <span class="n">allSignaturesValid</span> <span style="color: #aa2211">?</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"All signatures are valid."</span> <span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Atleast one signature has problem."</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_pageView</span><span style="color: #aa2211">-></span><span class="n">displayMessage</span><span class="p">(</span> <span class="n">message</span><span class="p">,</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">allSignaturesValid</span> <span style="color: #aa2211">?</span> <span class="n">PageViewMessage</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Info</span> <span class="p">:</span> <span class="n">PageViewMessage</span><span style="color: #aa2211">::</span><span class="n">Error</span><span class="p">,</span> <span style="color: #601200">10000</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">atleast is two words i think, also "has problem" is not correct either i think.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13484#inline-72110">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.h:237</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">void</span> <span style="color: #004012">enableLayers</span><span class="p">(</span> <span style="color: #aa4000">bool</span> <span class="n">enable</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">slotShowSigStatus</span><span class="p">(</span> <span style="color: #aa4000">bool</span> <span class="n">allSignaturesValid</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ideally we should not have "slot" in the name, just what the function does, also Sig -> Signature please, no need to make it shorter :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13484#inline-72113">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageview.cpp:5550</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span class="n">allSignaturesValid</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span> <span class="n">PageViewItem</span> <span style="color: #aa2211">*</span> <span class="n">item</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">items</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this logic belongs here, it should be in document, this is not an "UI" thing, more a "core" thing.</p>
<p style="padding: 0; margin: 8px;">What do you think?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13484">https://phabricator.kde.org/D13484</a></div></div><br /><div><strong>To: </strong>chinmoyr, aacid<br /><strong>Cc: </strong>okular-devel, ngraham, aacid<br /></div>