<table><tr><td style="">tobiasdeiminger added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13203">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13203#inline-70005">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dileepsankhla</span> wrote in <span style="color: #4b4d51; font-weight: bold;">editannottooldialog.cpp:128</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">There is no any problem in the newer Okular version as what I have found is that it respects both #RRGGBB and #AARRGGBB formats. I don't know about the older version but it should be both forward and backward compatible. And I agree there should be consistency in the color formats.<br />
So if we adopt the new color format in the default tools in tools.xml, do we need to alter all the color entries? Or is it okay to have two color formats?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">I don't know about the older version but it should be both forward and backward compatible.</p></blockquote>
<p style="padding: 0; margin: 8px;">Test for forwards compatibility (<a href="https://en.wikipedia.org/wiki/Forward_compatibility" class="remarkup-link" target="_blank" rel="noreferrer">def:</a> "allows a system to accept input intended for a later version of itself") is easy.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">open a test.txt file in Okular with <a href="https://phabricator.kde.org/D13203" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13203</a> applied</li>
<li class="remarkup-list-item">add some annotations (inline note, line, ...)</li>
<li class="remarkup-list-item">save document to test.okular document archive</li>
</ul>
<p style="padding: 0; margin: 8px;">Because tools.xml was not yet patched to #AARRGGBB for all annotations, just let's simulate this patch:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">unpack the okular archive</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ unzip test.okular</span></pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item">edit metadata.xml and change all <annotation>...color=...</annotation> attributes to #AARRGGBB format.</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ vi metadata.xml </span><span style="color: #aa4000"># do :%s/color="#/color="#00/g</span></pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item">pack the archive again</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ zip test_aarrggbb.okular content.xml test.txt metadata.xml</span></pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item">Open test_aarrggbb.okular in older Okular (i.e. compiled from master branch, or just a recent Ubuntu installation)</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ okular test_aarrggbb.okular</span></pre></div>
<ul class="remarkup-list">
<li class="remarkup-list-item">Check if annotations are painted with colors as expected.</li>
</ul>
<p style="padding: 0; margin: 8px;">Just tried it, it works.</p>
<p style="padding: 0; margin: 8px;">Can you please come up with similar test steps for backwards compatiblity (<a href="https://en.wikipedia.org/wiki/Backward_compatibility" class="remarkup-link" target="_blank" rel="noreferrer">def:</a> "allows for interoperability with an older legacy system") and perform the test?</p>
<p style="padding: 0; margin: 8px;">Reconsidering it, I'm not sure if it's worth the while to open a new Differential patch for the tools.xml alpha channel patch. Probably it's ok to incorporate it in <a href="https://phabricator.kde.org/D13203" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13203</a>.</p>
<p style="padding: 0; margin: 8px;">But let's at least write both the forwards and backwards compatibility test steps down in the <a href="https://secure.phabricator.com/book/phabricator/article/differential_test_plans" class="remarkup-link" target="_blank" rel="noreferrer">Test Plan</a> field of <a href="https://phabricator.kde.org/D13203" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13203</a>. It's yet empty. May you please do this?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13203#inline-70005">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dileepsankhla</span> wrote in <span style="color: #4b4d51; font-weight: bold;">editannottooldialog.cpp:128</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">There is no any problem in the newer Okular version as what I have found is that it respects both #RRGGBB and #AARRGGBB formats. I don't know about the older version but it should be both forward and backward compatible. And I agree there should be consistency in the color formats.<br />
So if we adopt the new color format in the default tools in tools.xml, do we need to alter all the color entries? Or is it okay to have two color formats?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">So if we adopt the new color format in the default tools in tools.xml, do we need to alter all the color entries? Or is it okay to have two color formats?</p></blockquote>
<p style="padding: 0; margin: 8px;">I'm not sure if I understand this question. Of course not all color entries that appear somewhere in okular source code 😃 We shall just be consistent with</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QString color = m_stubann->style().color().name(QColor::HexArgb);</pre></div>
<p style="padding: 0; margin: 8px;">So adapt everything to #AARRGGBB that will affect Okular::Annotation::style()->color(). Afaikt this are the color=... attributes of <annotation> elements in tools.xml. But not the color=... attributes of <engine> elements, because they don't affect Okular::Annotation::style()->color(). Are there other places?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13203">https://phabricator.kde.org/D13203</a></div></div><br /><div><strong>To: </strong>dileepsankhla, tobiasdeiminger<br /><strong>Cc: </strong>ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel<br /></div>