<table><tr><td style="">michaelweghorn updated this revision to Diff 34821.<br />michaelweghorn retitled this revision from "PDF: Allow to ignore print margins" to "Add option to ignore print margins".<br />michaelweghorn edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-lacuespdrugivds/">(Show Details)</a><br />michaelweghorn edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-goxntw3j6gycgyc/">(Show Details)</a><br />michaelweghorn added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10974">View Revision</a></tr></table><br /><div><div><p>Changes to previous version:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">take over Albert's suggestion to make option available to all generators "as is" (except for fixing a minor typo in a comment ("cad" -> "can") (A big thanks to Albert!)</li>
<li class="remarkup-list-item">rename dialog option from "Fit to printable area" to "Ignore printer margins" and adapt variable names etc. accordingly</li>
<li class="remarkup-list-item">rebase onto current git master</li>
<li class="remarkup-list-item">Fix issue that hardware printer margins were still taken into account when option was set not to do so.</li>
</ol>
<p>Detail on 4): Further testing with more real printers showed that just passing<br />
the option "fit-to-page" to CUPS without explicitly setting any margins causes<br />
the defaults from the PPD to be used, which is not what is excpected.<br />
This is fixed now by explicitly passing '0'.</p>
<p>(Side note: I missed this at first, since values for the margins in the Qt print<br />
dialog currently don't seem to be initialized with the PPD default values.)</p>
<p><a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@aacid</a>: What's the right way to properly indicate that an important part of this<br />
was actually done by you (add you in the copyright, mention in the commit message,...)?</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">This adds a checkbox in the print dialog <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">to<br />
</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">to </span>make it possib<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">le to select whether or not to scale the printed</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">le to</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">documen</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">select whether or no</span>t to t<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">h</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">ak</span>e print<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">able area</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> margins into account</span> when printing.<div style="padding: 8px 0;">...</div>are <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">(not) passed based on</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">passed accordingly (either</span> the value<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> that was set</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">s set in the dialog or '0')</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">"Fit to</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">"Ignore</span> print<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">able area</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> margins</span>" checkbox that is <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">en</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">dis</span>abled by default.<div style="padding: 8px 0;">...</div>has been without this change.<br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">4) dis</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">4) En</span>able the "PDF options" -> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">"Fit to</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">"Ignore</span> print<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">able area"</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> margins"</span> checkbox and print again<div style="padding: 8px 0;">...</div>the "Force rasterize" option being set.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
<br />
6) Try steps 1-4 with other document formats supported by Okular and<br />
observe that they behave the same (except that the option is now in a<br />
tab called "Print Options" rather than "PDF Options").</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D10974?vs=29095&id=34821">https://phabricator.kde.org/D10974?vs=29095&id=34821</a></div></div><br /><div><strong>BRANCH</strong><div><div>michaelweghorn/WIP_update_D10974</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10974">https://phabricator.kde.org/D10974</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
core/document.cpp<br />
core/document.h<br />
core/fileprinter.cpp<br />
core/printoptionswidget.cpp<br />
core/printoptionswidget.h<br />
generators/poppler/generator_pdf.cpp<br />
generators/poppler/generator_pdf.h<br />
interfaces/printinterface.h<br />
part.cpp</div></div></div><br /><div><strong>To: </strong>michaelweghorn, Okular<br /><strong>Cc: </strong>okular-devel, aacid, ngraham<br /></div>