<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10932">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10932#225740" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D10932#225740</a>, <a href="https://phabricator.kde.org/p/ahmadosama/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ahmadosama</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Regarding the undo/redo stacks, the undo/redo command will not undo the whole reset, it will undo widgets somehow randomly.<br />
RadioButtons in the same page will be in the same undo command, as for TextLineEdit each single widget will be added separately to the undo/redo stack.</p>
<p>So triggering the reset action will result in adding several commands to the undo stack not just one, I am currently thinking of how to make the whole undo in a single command in the stack.</p></div>
</blockquote>
<p>So how this typically works is a QUndoCommand that holds all the other QUndoCommand</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, the "Reset Forms" and "Show Forms/Hide Forms" buttons are stacked beside each other, the user can easily mistake by clicking the "Reset" button instead of the "Show Forms" Button.</p></blockquote>
<p>I'd just remove it from the top bar, i don't see why we need reset forms in there.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I am currently thinking about fixing this too.</p></blockquote>
</div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10932#inline-55487">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ahmadosama</span> wrote in <span style="color: #4b4d51; font-weight: bold;">part.cpp:3359</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I added it to show the "reset forms" button in the displayed message, beside the "Show Forms" button.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think that's a good idea, do you think resetting the forms is as common as showing/hiding them?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10932#inline-55612">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.rc:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <Action name="view_toggle_forms"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <Action name="view_reset_forms"/>
</div><div style="padding: 0 8px; margin: 0 4px; "> </Menu>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You need to increase the version number at the top of the file.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10932">https://phabricator.kde.org/D10932</a></div></div><br /><div><strong>To: </strong>ahmadosama, Okular, aacid<br /><strong>Cc: </strong>ngraham, aacid, Okular, michaelweghorn<br /></div>