<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9328" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9328#195937" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D9328#195937</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Better, but not perfect yet ;)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>There's no autotests in <a href="https://phabricator.kde.org/D8379" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D8379</a>, no?</p></blockquote>
<p>Seems I mixed it up with <a href="https://phabricator.kde.org/D8642" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D8642</a>, sorry.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list" start="2">
<li class="remarkup-list-item">OOM killed when changing sidebar size.</li>
</ol></blockquote>
<p>I suspect there are multiple issues triggered by sidebar resizing:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">OOM, which seems to be solved with your latest updates.</li>
<li class="remarkup-list-item">Unresponsiveness, which has been there before. Observation: This is not restricted to Okular, but extends to X. I cannot switch windows (or even move window focus via focus-follows-mouse), which is odd because normally even with all CPU cores busy (here some are idle, still) that's not a problem. I can move the mouse, but the pointer does not change. Maybe Okular has a blocking mouse cursor change call, or does too many of them? For now, I opened <a href="https://bugs.kde.org/show_bug.cgi?id=389411" class="remarkup-link" target="_blank" rel="noreferrer">Bug 389411</a> about this.</li>
<li class="remarkup-list-item">NEW issue since your latest updates:</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">ASSERT: "page()" in file okular/core/generator_p.cpp, line 129</tt> (Happened two times already, but not everytime.)</li>
</ul></div>
</blockquote>
<p>You got this one changing the size of the sidebar? or doing what?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I'm not sure about the next one, maybe you could comment whether this is related to the patch and if it is intentional or not:</p>
<ol class="remarkup-list" start="6">
<li class="remarkup-list-item">Text page generation not cancellable. This can be observed by comparing the reaction to <kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">F5</kbd> being pressed while doing incremental rendering vs. shortly after that. Alternatively, zoom in after rendering finished but thumbnail rendering did not start yet, where now you'd have to wait a while until rerendering triggers again.</li>
</ol></blockquote>
<p>It is cancellable, but wasn't being cancelled on closing the document (<a href="https://phabricator.kde.org/F5" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5</a>), I've fixed that now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>BRANCH</strong><div><div>cancellable (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9328" rel="noreferrer">https://phabricator.kde.org/D9328</a></div></div><br /><div><strong>To: </strong>aacid, ervin<br /><strong>Cc: </strong>rkflx, ervin, michaelweghorn, ngraham, Okular, aacid<br /></div>