<table><tr><td style="">mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8379" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8379#inline-37443" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator.cpp:407</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">page</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(</span> <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">observer</span><span class="p">(),</span> <span style="color: #aa4000">new</span> <span class="n">QPixmap</span><span class="p">(</span> <span class="n">QPixmap</span><span style="color: #aa2211">::</span><span class="n">fromImage</span><span class="p">(</span> <span class="n">image</span> <span class="p">)</span> <span class="p">),</span> <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">normalizedRect</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is <tt style="background: #ebebeb; font-size: 13px;">setPixmap</tt> old API? Why create a QPixmap on the heap? That should not be done, pass values instead.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8379#inline-37442" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator.h:581</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">         * This method can be called to trigger a partial pixmap update for the given request</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">         * Make sure you call it in a way it's executed in the main thread.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">         * @since 1.3</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">aka: "Must be called from the main thread."</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8379#inline-37444" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator_pdf.cpp:919</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">payload</span><span style="color: #aa2211">-></span><span class="n">timer</span><span class="p">.</span><span class="n">isActive</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">payload</span><span style="color: #aa2211">-></span><span class="n">timer</span><span class="p">.</span><span class="n">remainingTime</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">payload</span><span style="color: #aa2211">-></span><span class="n">timer</span><span class="p">.</span><span class="n">stop</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why is the timer active when there is no remaining time? when does this happen? can you add a comment please?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8379#inline-37445" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator_pdf.cpp:929</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">payload</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">PartialUpdatePayload</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">payloadA</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="n">payload</span><span style="color: #aa2211">-></span><span class="n">generator</span><span class="p">,</span> <span style="color: #766510">"signalPartialPixmapRequest"</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">,</span> <span class="n">Q_ARG</span><span class="p">(</span><span class="n">Okular</span><span style="color: #aa2211">::</span><span class="n">PixmapRequest</span><span style="color: #aa2211">*</span><span class="p">,</span> <span class="n">payload</span><span style="color: #aa2211">-></span><span class="n">request</span><span class="p">),</span> <span class="n">Q_ARG</span><span class="p">(</span><span class="n">QImage</span><span class="p">,</span> <span class="n">image</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">sending raw pointers over a queued connection sounds scary - who owns the pixmap request? will it really outlive everything? could you instead use a shared pointer or similar value type to ensure it really never gets destroyed in the middle?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8379" rel="noreferrer">https://phabricator.kde.org/D8379</a></div></div><br /><div><strong>To: </strong>aacid, Okular, mlaurent<br /><strong>Cc: </strong>mwolff, rkflx, ngraham, michaelweghorn, mlaurent, Okular, aacid<br /></div>