<table><tr><td style="">trufanov added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8415" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8415#162014" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8415#162014</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8415#160837" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8415#160837</a>, <a href="https://phabricator.kde.org/p/trufanov/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@trufanov</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8415#159049" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8415#159049</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Please consider fixing this in Qt before asking us to create a workaround.</p></div>
</blockquote>
<p>I'm fine with workarounded gwenview as well as working GIMP and ImageMagick.</p></div>
</blockquote>
<p>Is this your way of saying "i'm not interested in pursuing a fix in Qt"?</p></div>
</blockquote>
<p>I would be honered to commit a fix into Qt framework (never did yet). I'm also happy to commit something into KDE.<br />
But in my opinion it's most probably a libpng problem. And if I suggest a workaround to Qt team they'll answer me "Please consider fixing this in libpng before asking us to create a workaround." So I have to investigate libpng beforehand. I don't know png format specifications at all. And don't want to. That'll take time to investigate and a weeks of discussion with responsible teams.<br />
And then I'll face with one of 3 options:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">I need to add a warning level in binary "error/everything is ok" communication between Qt and libpng. And adjust Qt's images format plugin system. That would be best one.</li>
<li class="remarkup-list-item">It's indeed a libpng-only problem. And they may return no error in such cases. (And they can argue that this is by design, by png standard or breaks binary compatibility).</li>
<li class="remarkup-list-item">Most probable option - it's acdsee app problem. Perhaps, only N-years old acdsee version problem. Which is proprietary software and both Qt and libpng will ignore it.</li>
</ol>
<p>So, I just have no time for digging into this further.<br />
I have an app. I've got user feedback that some png images do not open. Got an example. I was surprised to find that some opensource Qt apps could open it and some could not and leveraged with this to fix my app. I'm fine. And I just wanted to share my findings in case they could be useful. So it just a bit less than feasible for me to keen digging into this,<br />
(Btw, the proposed patch is that I find out from just a gwenview, I've not checked why particular GIMP and ImageMagick has no such problem. The reason may be different.)</p>
<p>I would summarise this as following. This could be marked as WONT_FIX. My users are quite a specific guys which scan books and conservative enough to use weird software and its versions for years (or perhaps a decade) following manuals and trying to keep quality. If I'll face with file that is created by modern software I would be more keen to fix it.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8415" rel="noreferrer">https://phabricator.kde.org/D8415</a></div></div><br /><div><strong>To: </strong>trufanov, ngraham, Okular<br /><strong>Cc: </strong>aacid, progwolff<br /></div>