<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130235/">https://git.reviewboard.kde.org/r/130235/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2017, 9:07 p.m. UTC, <strong>Albert Astals Cid</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How do I make it go into effect when 'Ok' is clicked? I suppose there's some signal that gets emitted, but what's its name?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, that's not happening, also needed for https://bugs.kde.org/show_bug.cgi?id=384070</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Honestly, i don't like to have this option even if you add a million of warnings, people will select it and they'll either file a bug or shit on the internet about how crap Okular is.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't understand why an #ifdef protecting the option is not good for you?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is an idea for a compromise: Provide a command line option. For the developer, this enables fast and convenient switching between backends without reconfiguring/rebuilding, for the user it is very explicit to type something like "--use-totally-unsupported-and-very-experimental-arthur-backend".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for getting more contributors involved, I guess there are more effective channels to get the word out than a GUI option: Once available as an experimental feature in a released version, call for developers/testers in the release notes, in a blog post and on Reddit (/r/kde, /r/linux, …). To keep the excitement going, provide regular blog posts with achievements and testing requests on PlanetKDE with link submissions to Reddit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This sounds like a lot of work, but in reality is nothing more than a somewhat detailed copy of a Phabricator Diff summary with a screenshot of a new GUI option or old vs. improved rendering thrown in for good measure. For example, you could start with what's the advantage over Splash. (Could we finally get subpixel rendering for eligible pages? This seems like a much-wanted feature…) Then continue with the text rendering improvements you already did a couple of weeks back in Poppler. After that, mention the printing stuff in multiple installments (scaling, faster performance, …).</p></pre>
<br />
<p>- Henrik</p>
<br />
<p>On August 24th, 2017, 8:37 p.m. UTC, Oliver Sander wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Oliver Sander.</div>
<p style="color: grey;"><em>Updated Aug. 24, 2017, 8:37 p.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a new configuration option to the pdf backend options: the user can select between the poppler Splash or Arthur backends. Of course Splash is the default, but it's nice to have the choice -- I use it to debug Arthur.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need some help, though (still Qt newbie). With the current patch, backend changes do not go into effect until the document is reloaded. How do I make it go into effect when 'Ok' is clicked? I suppose there's some signal that gets emitted, but what's its name?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, It'd be good to add a 'here be dragons' tooltip to the Arthur choice. Is that possible?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/poppler/conf/pdfsettings.kcfg <span style="color: grey">(65ea82d8d)</span></li>
<li>generators/poppler/conf/pdfsettingswidget.ui <span style="color: grey">(488ad3099)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(2a73ca205)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130235/diff/1/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>