<table><tr><td style="">aacid accepted this revision.<br />aacid added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7996" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different.</p>

<p>every single instance is broken<br />
<a href="https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082</a><br />
<a href="https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147</a><br />
<a href="https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162</a><br />
<a href="https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140</a></p>

<p>meh, i'll forget this to make my life better.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>BRANCH</strong><div><div>Applications/17.08</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7996" rel="noreferrer">https://phabricator.kde.org/D7996</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, Okular, aacid<br /><strong>Cc: </strong>aacid, Okular<br /></div>