<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7671" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7671#142933" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7671#142933</a>, <a href="https://phabricator.kde.org/p/progwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@progwolff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7671#142826" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7671#142826</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@aacid</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I don't know who told you this is the correct behaviour of kdirwatch, but i kind of disagree.</p>
<p>Since we're not watching the file but *also* the folder.</p></div>
</blockquote>
<p>From the KDirWatch class reference:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>void KDirWatch::dirty ( const QString & path ) signal<br />
Emitted when a watched object is changed.</p>
<p>For a directory this signal is emitted when files therein are created or deleted. [...]</p>
<p>When you watch a directory, changes in the size or attributes of contained files may or may not trigger this signal to be emitted depending on which backend is used by KDirWatch.</p></blockquote>
<p>So, let's assume we have a file <tt style="background: #ebebeb; font-size: 13px;">path/file</tt> loaded in Okular and we watch the directory <tt style="background: #ebebeb; font-size: 13px;">path</tt> for changes. We remove <tt style="background: #ebebeb; font-size: 13px;">file</tt> and create a new file named <tt style="background: #ebebeb; font-size: 13px;">file</tt>. The directory <tt style="background: #ebebeb; font-size: 13px;">path</tt> will get dirty, as a new file is created.<br />
This means, a signal <tt style="background: #ebebeb; font-size: 13px;">dirty("path")</tt> is emitted. However, Okular does not reload the document when the signal <tt style="background: #ebebeb; font-size: 13px;">dirty("path")</tt> is received, but waits for a signal <tt style="background: #ebebeb; font-size: 13px;">dirty("path/file")</tt>.</p></div>
</blockquote>
<p>No, the code doesn't wait *only* for a dirty for path/file, read Part::slotFileDirty better</p>
<p>The problem here is that dirty for the path is not being emitted, <a href="https://mail.kde.org/pipermail/kde-frameworks-devel/2017-August/048813.html" class="remarkup-link" target="_blank" rel="noreferrer">https://mail.kde.org/pipermail/kde-frameworks-devel/2017-August/048813.html</a> if the dirty for the dir was getting emitted on delete and on addition i'm positive this would work.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The behaviour of KDirWatch might not be the most convenient, but from my perspective it is consistent with the documentation.<br />
Maybe the docs could be a little clearer at this point, like Henrik and Oliver proposed.</p>
<hr class="remarkup-hr" />
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7671#142844" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7671#142844</a>, <a href="https://phabricator.kde.org/p/rkflx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@rkflx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>(Julian: Sorry to intrude, feel free to pick up from here.)</p></div>
</blockquote>
<p>Always happy when someone contributes good ideas to a discussion.</p></blockquote>
</div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7671" rel="noreferrer">https://phabricator.kde.org/D7671</a></div></div><br /><div><strong>To: </strong>progwolff, aacid<br /><strong>Cc: </strong>sander, rkflx, Okular, aacid<br /></div>