<table><tr><td style="">rkflx updated this revision to Diff 19133.<br />rkflx edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-cbqlhqsqaaco7b6/" rel="noreferrer">(Show Details)</a><br />rkflx edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-k64bbv3liz4zdjj/" rel="noreferrer">(Show Details)</a><br />rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7594" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Plug multiple leaks and prevent a segfault by adding another patch to the imported synctex code.</p>

<p>(The patch seems simple, but the nested nature of the leaks and the scattered >8kLOC of C code made this quite an endeavor.)</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>- Two new patches to fix more compiler warnings<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
- New patch: Plug multiple leaks and prevent a segfault</span><br />
<br />
TODO for later:<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>- Shift-clicking on a word in a simple pdf opens Kate with the corresponding tex line.<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">-</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">- Forward and backward search in Kile seems to work.<br />
-</span> Works with <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">tex</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">synctex</span> files from both TeXLive 2015 and 2017.<br />
- PartTest::testForwardPDF still passes.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
- No additional memory leaks in autotests and with basic synctex and non-synctex usage of Okular.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D7594?vs=18902&id=19133" rel="noreferrer">https://phabricator.kde.org/D7594?vs=18902&id=19133</a></div></div><br /><div><strong>BRANCH</strong><div><div>synctex-update (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7594" rel="noreferrer">https://phabricator.kde.org/D7594</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/parttest.cpp<br />
core/document.cpp<br />
core/document_p.h<br />
core/synctex/patches/00-disable-SYNCTEX_INLINE.diff<br />
core/synctex/patches/01-fix-win32-define.diff<br />
core/synctex/patches/04-gcc-specify-printf-format.diff<br />
core/synctex/patches/05-fix-error-formats.diff<br />
core/synctex/patches/06-mingw-_synctex_error.diff<br />
core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff<br />
core/synctex/patches/08-fix_cpp_comments.diff<br />
core/synctex/patches/09-fix_path_comparison.diff<br />
core/synctex/patches/10-fix-typo.diff<br />
core/synctex/patches/11-fix-unused-parameters-warnings.diff<br />
core/synctex/patches/12-omit-no-file-warning.diff<br />
core/synctex/patches/13-fix-Wundef-warnings.diff<br />
core/synctex/patches/14-fix-misc-compiler-warnings.diff<br />
core/synctex/patches/15-prevent-leaks-and-segfault.diff<br />
core/synctex/patches/series<br />
core/synctex/synctex_parser.c<br />
core/synctex/synctex_parser.h<br />
core/synctex/synctex_parser_advanced.h<br />
core/synctex/synctex_parser_local.h<br />
core/synctex/synctex_parser_readme.md<br />
core/synctex/synctex_parser_readme.txt<br />
core/synctex/synctex_parser_utils.c<br />
core/synctex/synctex_parser_utils.h<br />
core/synctex/synctex_parser_version.txt</div></div></div><br /><div><strong>To: </strong>rkflx, Okular, sander, Kile<br /><strong>Cc: </strong>mludwig, aacid<br /></div>