<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130226/">https://git.reviewboard.kde.org/r/130226/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/130226/diff/1/?file=499024#file499024line829" style="color: black; font-weight: bold; text-decoration: underline;">generators/chm/lib/ebook_chm.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">829</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">qFatal</span> <span class="p">(</span><span class="s">"Could not detect LCID"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we want this to be a qwarning again?</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On agost 16th, 2017, 12:54 p.m. UTC, Gilbert Assaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Gilbert Assaf.</div>
<p style="color: grey;"><i>Updated ago. 16, 2017, 12:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch updates our copy of the chm lib from kchmviewer. The lib files itself are an unmodified copy from kchmviewer 7.7, only our generator needed some changes. In contrast to kchmviewer we still use khtml and therefor still need msits.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibZip.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/CMakeLists.txt <span style="color: grey">(5eedf4ebb61237f92d5bbf64c216123140d27fd3)</span></li>
<li>generators/chm/CMakeLists.txt <span style="color: grey">(83abe4e24e03b24622117156badb76a1b9d735da)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(1485bc8aae60d662dfc0c01afa2f664dbba6382f)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(b6a770ece0d46cb7874bfdf388bae8074d240149)</span></li>
<li>generators/chm/lib/bitfiddle.h <span style="color: grey">(eb15b0fa9b0d13b27170be76828631d8328b3109)</span></li>
<li>generators/chm/lib/ebook.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_chm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_chm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_chm_encoding.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_chm_encoding.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_epub.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_epub.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_search.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_search.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/ebook_url.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helper_entitydecoder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helper_entitydecoder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helper_search_index.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helper_search_index.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubcontainer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubcontainer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubcontent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubcontent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubtoc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/helperxmlhandler_epubtoc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/lib/lchmurlhandler.h <span style="color: grey">(35133c41d764de551a350a240d8ee43d07f84716)</span></li>
<li>generators/chm/lib/lchmurlhandler.cpp <span style="color: grey">(9d98d87e147539ef30817b3c66a040aa750575ad)</span></li>
<li>generators/chm/lib/libchmfile.h <span style="color: grey">(cb739ac7914d4856a5f0e8e6793d78e68b0c9628)</span></li>
<li>generators/chm/lib/libchmfile.cpp <span style="color: grey">(60d03bc267eff759495af44b333448a55071b023)</span></li>
<li>generators/chm/lib/libchmfile_search.cpp <span style="color: grey">(76532b18282913ff97c8509d8e384ec0b1f48dfb)</span></li>
<li>generators/chm/lib/libchmfileimpl.h <span style="color: grey">(f8d7cc11269a2688fd8b58a30d718ff911b051b3)</span></li>
<li>generators/chm/lib/libchmfileimpl.cpp <span style="color: grey">(d10602028e958e7feded362b2ab58e32ca1d1ff0)</span></li>
<li>generators/chm/lib/libchmtextencoding.h <span style="color: grey">(5228b04c10718d407fc49df2e69d220d4efff67c)</span></li>
<li>generators/chm/lib/libchmtextencoding.cpp <span style="color: grey">(0ed3f0710360c7bab113a35c7896e6bbd6664d20)</span></li>
<li>generators/chm/lib/libchmtocimage.h <span style="color: grey">(c0d98b3ba27596a731fd0ab24386578f6c58fdf8)</span></li>
<li>generators/chm/lib/libchmtocimage.cpp <span style="color: grey">(2952e8604d8c01360eace2826bbf5dc428155ff1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130226/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>