<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6268" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-29930" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagepainter.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QRect</span> <span class="n">scaledCrop</span> <span style="color: #aa2211">=</span> <span class="n">crop</span><span class="p">.</span><span class="n">geometry</span><span class="p">(</span> <span class="n">scaledWidth</span><span class="p">,</span> <span class="n">scaledHeight</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #004012">dScaledCrop</span><span class="p">(</span><span class="n">QRectF</span><span class="p">(</span><span class="n">scaledCrop</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">scaledCrop</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">scaledCrop</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">scaledCrop</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">).</span><span class="n">toAlignedRect</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">can you add some comments on your "d" prefix.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-29929" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagepainter.cpp:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">p</span> <span style="color: #aa2211">!=</span> <span style="color: #304a96">NULL</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">pixmap</span> <span style="color: #aa2211">=</span> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">copy</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">pixmap</span><span class="p">.</span><span class="n">setDevicePixelRatio</span><span class="p">(</span> <span class="n">qApp</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatio</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we don't want to be doing this - copy does a deep copy which is expensive</p>

<p style="padding: 0; margin: 8px;">QPixmap pixmap = *p would probably work as well, and that shares the underlying image data.</p>

<p style="padding: 0; margin: 8px;">or we could just use p for this section, it doesn't seem like pixmap is used outside here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-29931" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">presentationwidget.cpp:842</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #74777d">// then blend the overlay (a piece of) over the background</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">m_lastRenderedOverlay</span><span class="p">.</span><span class="n">save</span><span class="p">(</span><span style="color: #766510">"/tmp/overlay.png"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">QRect</span> <span class="n">ovr</span> <span style="color: #aa2211">=</span> <span class="n">m_overlayGeometry</span><span class="p">.</span><span class="n">intersected</span><span class="p">(</span> <span class="n">r</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6268" rel="noreferrer">https://phabricator.kde.org/D6268</a></div></div><br /><div><strong>To: </strong>hetzenecker, davidedmundson, aacid<br /><strong>Cc: </strong>sander, anthonyfieroni, Okular, aacid<br /></div>