<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130187/">https://git.reviewboard.kde.org/r/130187/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juli 24th, 2017, 11:08 vorm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i'd be happier if we don't touch the code in lib/ and kio-msits since it's "copied" from kchmviewer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At some point it would make sense if someone has time to go and see how much kchmviewer code has changed and if it makes sense updating our "copy".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you think?</p></pre>
</blockquote>
<p>On Juli 24th, 2017, 4:03 nachm. UTC, <b>Gilbert Assaf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds reasonable. I will look into this.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kchmviewer did a rewrite of those classes a few years ago. I suggest we use their current version and integrate them in okular. Although we might need a rewrite of our generator_chm class.</p></pre>
<br />
<p>- Gilbert</p>
<br />
<p>On Juli 20th, 2017, 2:40 nachm. UTC, Gilbert Assaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Gilbert Assaf.</div>
<p style="color: grey;"><i>Updated Juli 20, 2017, 2:40 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Removes lib/lchmurlhandler.cpp (contains no code)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Use keyword override</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Usage of proper Include Guards</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Fixes order of includes</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Introduces usage of nullptr</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Introduces usage of auto</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Removes usage of QString:null</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With clang4.0
some work was done with clang-tidy: https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/chm/CMakeLists.txt <span style="color: grey">(83abe4e24e03b24622117156badb76a1b9d735da)</span></li>
<li>generators/chm/autotests/chmgeneratortest.cpp <span style="color: grey">(6b0b8efc7e9395d137f2cd36876e8197accbfc16)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(1485bc8aae60d662dfc0c01afa2f664dbba6382f)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(b6a770ece0d46cb7874bfdf388bae8074d240149)</span></li>
<li>generators/chm/kio-msits/msits.cpp <span style="color: grey">(50bac0c100b9dd816d55a817c021ff083e3d5202)</span></li>
<li>generators/chm/lib/lchmurlhandler.h <span style="color: grey">(35133c41d764de551a350a240d8ee43d07f84716)</span></li>
<li>generators/chm/lib/lchmurlhandler.cpp <span style="color: grey">(9d98d87e147539ef30817b3c66a040aa750575ad)</span></li>
<li>generators/chm/lib/libchmfileimpl.h <span style="color: grey">(f8d7cc11269a2688fd8b58a30d718ff911b051b3)</span></li>
<li>generators/chm/lib/libchmfileimpl.cpp <span style="color: grey">(d10602028e958e7feded362b2ab58e32ca1d1ff0)</span></li>
<li>generators/chm/lib/libchmtextencoding.cpp <span style="color: grey">(0ed3f0710360c7bab113a35c7896e6bbd6664d20)</span></li>
<li>generators/chm/lib/libchmtocimage.h <span style="color: grey">(c0d98b3ba27596a731fd0ab24386578f6c58fdf8)</span></li>
<li>generators/chm/lib/libchmtocimage.cpp <span style="color: grey">(2952e8604d8c01360eace2826bbf5dc428155ff1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130187/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>