<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6268" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>qApp->DPR can change within the lifespan of the app; for example plugging in a new monitor can change things. <br />
This does mean it's very important to keep the metadata of the pixmap's dpr with the pixmap. It ends up simpler and safer overall.</p>
<p>Doesn't mean we need to break ABI though.</p>
<hr class="remarkup-hr" />
<p><a href="https://phabricator.kde.org/p/hetzenecker/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@hetzenecker</a></p>
<p>There are two breaks RequestPixmap::RequestPixmap and Page::_o_nearest</p>
<hr class="remarkup-hr" />
<p>For requestPixmap we're sure to not process any screen events in the meantime, so you can use qApp->devicePixelRatio() in the two places in document and in the line in generator.</p>
<p>For use of Page::_o_nearest you can't.<br />
However, there is an easy way to keep ABI for this sort of thing.</p>
<p>If you have<br />
someMethod(int a) and want to change it to someMethod(int a, qreal dpr)</p>
<p>keep both, but make the first method simply call the second with a default parameter.</p>
<hr class="remarkup-hr" /></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-26751" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator.cpp:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">request</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">page</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setPixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">request</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">observer</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">QPixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QPixmap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromImage</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">img</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">request</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">normalizedRect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">QPixmap</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">p</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">QPixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QPixmap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromImage</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">img</span></span><span class="bright"> </span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">setDevicePixelRatio</span><span class="p">(</span> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatioF</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">page</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setPixmap</span><span class="p">(</span> <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">observer</span><span class="p">(),</span> <span class="n">p</span><span class="p">,</span> <span class="n">request</span><span style="color: #aa2211">-></span><span class="n">normalizedRect</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">sure about this one?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6268" rel="noreferrer">https://phabricator.kde.org/D6268</a></div></div><br /><div><strong>To: </strong>hetzenecker, davidedmundson, aacid<br /><strong>Cc: </strong>sander, anthonyfieroni, Okular, aacid<br /></div>