<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6268" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>"Test plan" simply needs to be a list of things you've tried doing so the maintainers can point out if there's any parts you've not thought about.</p>
<p>So saying if you tested annotations and what types of files you opened, checked with zoom = 100%..that sort of thing.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-25860" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagepainter.cpp:75-76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">dScaledWidth</span> <span style="color: #aa2211">=</span> <span class="n">floor</span><span class="p">(</span><span class="n">scaledWidth</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">dScaledHeight</span> <span style="color: #aa2211">=</span> <span class="n">floor</span><span class="p">(</span><span class="n">scaledHeight</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #004012">dLimits</span><span class="p">(</span><span class="n">QRectF</span><span class="p">(</span><span class="n">limits</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">limits</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">limits</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">limits</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">).</span><span class="n">toAlignedRect</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why?</p>
<p style="padding: 0; margin: 8px;">(maybe ceil() ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-25861" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagepainter.cpp:410</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// highlight composition (product: highlight color * destcolor)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> QRect highlightRect = r.geometry( dScaledWidth, dScaledHeight ).translated( -dScaledCrop.topLeft() ).intersected( dLimits );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If the code below works, I'd avoid changing it.</p>
<p style="padding: 0; margin: 8px;">Painting something on top isn't quite the same as the exitsing multiplying the two values together, and the old code has that //for odt or epub hack swapping black pixels for white ones.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6268#inline-25859" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagepainter.cpp:911</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">void</span> <span class="n">PagePainter</span><span style="color: #aa2211">::</span><span class="n">scalePixmapOnImage</span> <span class="p">(</span> <span class="n">QImage</span> <span style="color: #aa2211">&</span> <span class="n">dest</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QPixmap</span> <span style="color: #aa2211">*</span> <span class="n">src</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">scaledWidth</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">scaledHeight</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span style="color: #aa2211">&</span> <span class="n">cropRect</span><span class="p">,</span> <span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format</span> <span class="n">format</span> <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you explain on Phabricator the changes you've made in PagePainter, and that benchmarking you did.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6268" rel="noreferrer">https://phabricator.kde.org/D6268</a></div></div><br /><div><strong>To: </strong>hetzenecker, davidedmundson<br /><strong>Cc: </strong>Okular, aacid<br /></div>