<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129773/">https://git.reviewboard.kde.org/r/129773/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Hartmut Brüning.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=366276">366276</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I introduced a m_exitFullScreenAction that listens on escape key. It is active in full screen mode only. I tested that escape key in menu or dialogs are not affected by this change.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">press escape in normal mode
-> nothing happens -> ok
clicked into menu, press escape
-> menu closes -> ok
opened configure menu, press escape
-> configure menu closes -> ok
opened file dialog, press escape
-> file dialog closes -> ok
switched to fullscreen, press escape
-> fullscreen closes -> ok
switched to fullscreen, right click, close fullscreen
-> fullscreen closes -> ok
switched to fullscreen, right click, press escape, press escape
-> context menu opens, closes and fullscreen closes -> ok
press Ctrl+Shift+F, press Ctrl+Shift+F -> fullscreen opens and closes
-> ok
press Ctrl+Shift+F, press escape -> fullscreen opens and closes
-> ok
switch to fullscreen, terminate okular, start reokular, press escape
-> okular starts in fullscreen and closes fullscreen -> ok</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/shell.h <span style="color: grey">(d015b3fc)</span></li>
<li>shell/shell.cpp <span style="color: grey">(448b9ff7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>