<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129584/">https://git.reviewboard.kde.org/r/129584/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 2nd, 2016, 12:50 a.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First past is correct i guess, somehow qimage* lost the hability to load eps files.
But the second part i'd prefer if you could try porting https://github.com/KDE/okular/commit/3f1ec4cee7066b8208f084621787c7740e68d59d that effectevely should fix this problem in a better way and somehow it got lost in the KF5 port.</pre>
</blockquote>
<p>On December 2nd, 2016, 4:39 p.m. CET, <b>Wolfgang Bauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kimageformats contains an eps plugin for qimageio though.
https://cgit.kde.org/kimageformats.git/tree/src/imageformats</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okular from git master displays eps files fine here using the kimgio backend.
Though spectre would still be the better choice of course.</p></pre>
</blockquote>
<p>On December 4th, 2016, 1:06 a.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On my system (Debian Unstable) kimgio says unsupported file format. I just submitted a new review request that can replace the last hunk.</p></pre>
</blockquote>
<p>On December 4th, 2016, 1:11 a.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you install kimageformat-plugins?</p></pre>
</blockquote>
<p>On December 4th, 2016, 8:18 p.m. CET, <b>Miklós Máté</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't even know that package existed.</p></pre>
</blockquote>
<p>On December 8th, 2016, 11:37 p.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did https://cgit.kde.org/okular.git/commit/?h=Applications/16.12&id=ecf54e42035e7c96a0c0a435ba01d1b3483d032a</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I thing we can now discard this review request, now if the kimgio generator was the first choice (that isn't anymore due to your other review request) and it failed it would try the next generator in offer instead of failing directly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you agree?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, that looks good.</p></pre>
<br />
<p>- Miklós</p>
<br />
<p>On November 29th, 2016, 4:13 p.m. CET, Miklós Máté wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Miklós Máté.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2016, 4:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There were two problems:
- kimgio backend advertised eps support, but it doesn't really support it
- txt backend had the same priority as spectre, and sort() happened to put them in the wrong order</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/kimgio/libokularGenerator_kimgio.json <span style="color: grey">(e109268)</span></li>
<li>generators/kimgio/okularApplication_kimgio.desktop <span style="color: grey">(db893ed)</span></li>
<li>generators/kimgio/okularKimgio.desktop <span style="color: grey">(983c300)</span></li>
<li>generators/kimgio/org.kde.mobile.okular_kimgio.desktop <span style="color: grey">(14ffe30)</span></li>
<li>generators/kimgio/org.kde.okular-kimgio.metainfo.xml <span style="color: grey">(a0aa40a)</span></li>
<li>generators/txt/libokularGenerator_txt.json <span style="color: grey">(97325db)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129584/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>