<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127628/">https://git.reviewboard.kde.org/r/127628/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 11th, 2016, 9:09 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the strigi part, just kill it.</p></pre>
</blockquote>
<p>On April 12th, 2016, 9:19 a.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And I guess all eyes will be on me to port the other part to KF5? (Notice how I steered clear of that ) =)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just put a big todo message/warning on the cmakelists, since you're not commititng to master whoever finishes it in the frameworks branch has to finish it before merging to master.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On April 10th, 2016, 5:32 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics and Okular.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated April 10, 2016, 5:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdegraphics-mobipocket
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't pay attention for a split second, wondered how the KF5 Okular version could use a Qt4-based libqmobipocket and instead of checking (and seeing the corresponding module isn't built ATM) I thought I'd try and build at least libqmobipocket against Qt 5.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The result is the attached patch. Very much a work in progress, but since no effort has yet been made to port this particular package to KF5 I thought I'd share.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've tried to ensure that the Qt4/KDE4 and Qt5(/KF5) versions can be coinstalled under the assumption that the KDE4 header files are not installed under ${prefix}/include (but e.g. under ${prefix}/include/KDE4 like on my system). That can be achieved easily enough by configuring kdelibs4 with <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-DINCLUDE_INSTALL_DIR=${prefix}/include/KDE4</code>).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure why the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">STRIGI_FOUND</code> token isn't defined in my <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">TARGET_QT5</code> cmake code path, but found a workaround which suffices for a proof-of-concept implementation.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It will probably be relatively trivial to port the thumbnailer component too but my not-so-rainy sunday afternoon is now over (IOW, I'll let myself be beaten to it happily).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds against Qt 5.6.0 on OS X and Linux.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ea2e644)</span></li>
<li>QMobipocket5Config.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>QMobipocketConfig.cmake <span style="color: grey">(d615afc)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(90fc229)</span></li>
<li>lib/mobipocket.cpp <span style="color: grey">(5b731b4)</span></li>
<li>lib/qmobipocket_export.h <span style="color: grey">(923134a)</span></li>
<li>strigi/CMakeLists.txt <span style="color: grey">(895284f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127628/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>