<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127366/">https://git.reviewboard.kde.org/r/127366/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry I've been meaning to test this a bit more and only got to it today.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have a couple of minor comments:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The corner boxes do not seem to work - even though the mouse icon changes to indicate resizing, left-clicking causes the annotation to become unselected. That looks like such an obvious thing that perhaps it is a bug that has crept in, or is strangely dependent on my particular build?</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The mouse icon changes could be made much better. Could the cursor not first (ie before an annotation has been selected) change to a pointer when over a point that left-clicking would select an annotation? When an annotation is selected, the "move annotation" (ie the vertical cross) is currently maintained even when the mouse cursor is no longer over the annotation itself, ie that left-clicking will not produce movement of the annotation.</p>
</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">More generally in terms of UI I really like the "select then operate on" model, and would suggest that, once an annotation has been selected, a range of functions (most obviously delete/edit/properties of annotation but also cut/copy and others) then become accessible through a context-dependent right-click menu?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds interesting... who would eventually care about merging?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think you are way ahead of me, and I am looking forward to going over your patch to learn how to do a few things. That said, I have contributed one tiny review request: https://git.reviewboard.kde.org/r/127496/ but haven't had any response yet.</p></pre>
<br />
<p>- Jonathan Schultz</p>
<br />
<p>On April 5th, 2016, 8:02 a.m. UTC, Tobias Deiminger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Tobias Deiminger.</div>
<p style="color: grey;"><i>Updated April 5, 2016, 8:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This diff adds an annotation resize feature to okular (see Bug 177778).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:
If you left-click at an annotation, it gets selected and 8 resize handles appear on the corners/edges of the selection rectangle. When cursor is moved over one of the handles, the cursor shape indicates resize mode (everywhere else on the annotation means "move", just as it was before resize feature was added). Press ESC, or click an area outside the annotation to cancel selection. Feature is only applicable for annotation types AText, AStamp and AGeom.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Notable changes:
It works by eventually changing AnnotationPrivate::m_boundary and notifying generator (i.e. poppler) about that change, similar to the existing move functionality.
-Separated annotation state handling out of PageView into a new class MouseAnnotation (ui/pageviewmouseannotation.cpp)
-Added method Document::adjustPageAnnotation, backed by a QUndoCommand class Okular::AdjustAnnotationCommand
-Added method Annotation::adjust
-Draw resize handles and selection boundary in MouseAnnotation::routePaint
-Draw only a bounding rectangle during resize, if annotation is rendered externally</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TODO:
-Add test cases once requirements are fixed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Resize and move work
-for types AText, AStamp and AGeom
-on all pages of document
-when viewport position changes
-when zoom level changes
-for all page rotations (0°, 90°, 180°, 270°)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Selection is canceled
-when currently selected annotation is deleted
-on mouse click outside of currently selected annotation
-ESC is pressed</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Viewport is shifted when mouse cursor during move/resize comes close to viewport border.
Resize to negative is prevented.
Tiny annotations are still selectable.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(97e8db6e4a704fd34331fad7b7628ca2248b62d8)</span></li>
<li>core/annotations.h <span style="color: grey">(4f107440dc824fd9049a30082befd18642e63895)</span></li>
<li>core/annotations.cpp <span style="color: grey">(e02994688414bdf485b308d6ef122ee2eff3fbaf)</span></li>
<li>core/annotations_p.h <span style="color: grey">(07b124a4fae40b7a983aa382ae824125e6d25746)</span></li>
<li>core/document.h <span style="color: grey">(63f58741bd6680a673945a7b7c05a10130968beb)</span></li>
<li>core/document.cpp <span style="color: grey">(6953b1fb0dc29a375be7ff331a2a2bccce975366)</span></li>
<li>core/document_p.h <span style="color: grey">(fda23275033645ea67f5ad9d27341fc4635ede34)</span></li>
<li>core/documentcommands.cpp <span style="color: grey">(95aded51d73a3d3b98ff26284c9c46fc5c9cf0ca)</span></li>
<li>core/documentcommands_p.h <span style="color: grey">(17394f2a25b187cf4aff66b3a7f891b81be5acdd)</span></li>
<li>generators/poppler/annots.cpp <span style="color: grey">(8cde64833831ec833b3be552608cff99d38f8e63)</span></li>
<li>tests/translateannotationtest.cpp <span style="color: grey">(184b9474e6072a991a5ee5f1116bf7a9ef10cadc)</span></li>
<li>ui/pagepainter.h <span style="color: grey">(68b241658162d9bd6eb187efc594ef17ea99d899)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(3bcd8bc4cfe7471bc3c21cfcd3cff50b8a8d49ee)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(3ebf7dcb04aa1942e02f49133d98081e2bbb565c)</span></li>
<li>ui/pageviewmouseannotation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/pageviewmouseannotation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127366/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>