<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127541/">https://git.reviewboard.kde.org/r/127541/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127541/diff/1/?file=455037#file455037line428" style="color: black; font-weight: bold; text-decoration: underline;">shell/shell.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">408</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="hl"> </span><span class="n"><span class="hl">m_fileformatsscanned</span></span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span> <span class="n">m_fileformats</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">428</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_fileformats</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">m_fileformatsscanned</code> has to be valid at this moment and even if it were not, the else block would fail (This is not strictly related to the feature, but as I was refactoring the code anyway, I decided to get rid of this.).</p></pre>
</div>
</div>
<br />
<p>- Jonathan Verner</p>
<br />
<p>On April 5th, 2016, 7:07 a.m. UTC, Jonathan Verner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jonathan Verner.</div>
<p style="color: grey;"><i>Updated April 5, 2016, 7:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=361292">361292</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch allows the user to import annotations from a different document into the currently opened document.
While importing, it tries to avoid adding duplicate annotations by looking whether an annotation with
the same uniqueName is not already present on the given page. It doesn't check whether the currently opened
document corresponds to the one where comments are imported from. It just loops over the pages starting
from 0 to the minimum of the size of the two files and for each page it imports the annotations.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested both manually on several files and also provided a simple automatic test in mainshelltest.cpp.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.h <span style="color: grey">(63f58741bd6680a673945a7b7c05a10130968beb)</span></li>
<li>core/document.cpp <span style="color: grey">(6953b1fb0dc29a375be7ff331a2a2bccce975366)</span></li>
<li>kdocumentviewer.h <span style="color: grey">(f99c69ef4ac8dbfb7ee600df7f97db7c62a409ab)</span></li>
<li>part.h <span style="color: grey">(44d032e496aacde0b8c239ed344a0f3eb39fa09b)</span></li>
<li>part.cpp <span style="color: grey">(d8f1750f33a903c1734857042b601b52d8d8e1f2)</span></li>
<li>shell/shell.h <span style="color: grey">(fea80acfbf91968d90babd281d199341b6370bbd)</span></li>
<li>shell/shell.cpp <span style="color: grey">(d80def41c2c17364557402654205a5c705a29d1f)</span></li>
<li>shell/shell.rc <span style="color: grey">(93fbc417588312792bab39b693c65e5d414c87c6)</span></li>
<li>tests/data/annots.pdf <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/mainshelltest.cpp <span style="color: grey">(a044895c1935c587552e875a98627e58d19ed443)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127541/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>