<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127328/">https://git.reviewboard.kde.org/r/127328/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okay, okularpart was really intended to be a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">MODULE</code> (a plugin, that is) but making it so breaks a lot of tests on Windows, because plugins can't be linked to there. All <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Settings</code> related link errors are due to that too.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not in position to fix this, so it would be better to just enhance my workarounds with yours. I've checked this doesn't break MSVC build.</p></pre>
<br />
<p>- Gleb Popov</p>
<br />
<p>On March 14th, 2016, 3:17 a.m. MSK, Thomas Friedrichsmeier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb Popov.</div>
<div>By Thomas Friedrichsmeier.</div>
<p style="color: grey;"><i>Updated March 14, 2016, 3:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Three parts to this patch:
1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not compiler-specific.
2) When compiling okularplugin, the existing definition of okularpart_EXPORTS on the generated settings.cpp does not work with MinGW, for reasons that I do not understand. Setting the definition on the whole target, instead, works.
3) The okularpart lib will automatically be named libokularpart, and subsequently not be found when trying to load it via KPluginLoader. Tell cmake to drop the "lib"-prefix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also:
- Discussion on list https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html
- A previous review request addressed issue 2 for MSVC https://git.reviewboard.kde.org/r/125742/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds on Windows with MinGW. Starts, and loads okularpart, successfully.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e17bc25)</span></li>
<li>interfaces/viewerinterface.h <span style="color: grey">(e9e76a2)</span></li>
<li>mobile/components/CMakeLists.txt <span style="color: grey">(e09326a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127328/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>