<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126193/">https://git.reviewboard.kde.org/r/126193/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2015, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two commits:</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port to new JSON plugin loading system</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This means Okular can now work without ksycoca and KDELibs4Support.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bring back the about backend dialog</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unit tests still pass, opening files works</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4aea44db6940d4a34c24d30d54c3980d2170e89f)</span></li>
<li>core/document.h <span style="color: grey">(1e49b3362574f70de49daefd4558e04cb0e1a423)</span></li>
<li>core/document.cpp <span style="color: grey">(04a29fd1be29f1c464b2d9d08ae20ba9e0b937ef)</span></li>
<li>core/document_p.h <span style="color: grey">(73f5797a5552f7590ad50f019893d9bf2844a90c)</span></li>
<li>core/generator.h <span style="color: grey">(b225dc1a5940fc07d35f0f545aedec10a5beb03a)</span></li>
<li>generators/CMakeLists.txt <span style="color: grey">(0e0d44a7ce2551a3794e130a84c2a13ab3046116)</span></li>
<li>generators/chm/CMakeLists.txt <span style="color: grey">(471258bd036ef453d021e350392c4adbf3c7d47e)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(5163d5f104da8bf517befeb702ba9aefee6b0236)</span></li>
<li>generators/chm/libokularGenerator_chmlib.desktop <span style="color: grey">(dc3ac9308fc2447f3b11f96c5618058ca95832fc)</span></li>
<li>generators/chm/libokularGenerator_chmlib.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/okularChm.desktop <span style="color: grey">(ed42bc25c87ee1fafe1a729d3f14f1c75e5784dd)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(deed292fd179535dfed129cdb6007b49668bafa9)</span></li>
<li>generators/comicbook/generator_comicbook.cpp <span style="color: grey">(dd5b0ffffe216150e521e234c9a00c9414cc0a87)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.desktop <span style="color: grey">(5a91a5fdd053819d75d28f93de152b9c904f41ff)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/okularComicbook.desktop <span style="color: grey">(1dded78f4245d2770f1431f7e02123c2fa681ac9)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: grey">(34dc1a139eaae868464fb158a35408000ffc2ed7)</span></li>
<li>generators/djvu/generator_djvu.cpp <span style="color: grey">(740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0)</span></li>
<li>generators/djvu/libokularGenerator_djvu.desktop <span style="color: grey">(887377998ce55802cd505c42e359919cb814d615)</span></li>
<li>generators/djvu/libokularGenerator_djvu.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/djvu/okularDjvu.desktop <span style="color: grey">(1c2fd43b63f071f9d726e1a605681d32bc93d25f)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: grey">(38f321a1118f68027a2e1e365f79ee607f67bfe7)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(2db4bc4303807f04776a8d0d7c20c46aff695bb2)</span></li>
<li>generators/dvi/libokularGenerator_dvi.desktop <span style="color: grey">(39edcfadf8fb0273c7b7f1bde2912566db605c61)</span></li>
<li>generators/dvi/libokularGenerator_dvi.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/dvi/okularDvi.desktop <span style="color: grey">(5c7d3a96021a887171a6d98f0693ad88bc967f29)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(41ecd23a4d04997aef297f190da8f1b06e0732d8)</span></li>
<li>generators/epub/generator_epub.cpp <span style="color: grey">(d8d8b07d24e897c3b27cdf13a99120f434f73e82)</span></li>
<li>generators/epub/libokularGenerator_epub.desktop <span style="color: grey">(14d64159fd2e51ce91de3abde3cb0380c9ffe0c8)</span></li>
<li>generators/epub/libokularGenerator_epub.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/epub/okularEPub.desktop <span style="color: grey">(2da8c9097f1764aaee675a183b4d4eb4586d44b1)</span></li>
<li>generators/fax/CMakeLists.txt <span style="color: grey">(22b595e2ff9ce3bac6cf82b4142da02e3732fbb6)</span></li>
<li>generators/fax/generator_fax.cpp <span style="color: grey">(823db2723f3373c058139a521861f7cd7a623cfb)</span></li>
<li>generators/fax/libokularGenerator_fax.desktop <span style="color: grey">(fcffa707b157a91f84a43a8c6e8ac5b93363fef9)</span></li>
<li>generators/fax/libokularGenerator_fax.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fax/okularFax.desktop <span style="color: grey">(8b86b91ed02b6e15547686e2f9a589f80516ce84)</span></li>
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(1ab52891e0772df8e301646c1a259fd49b229f89)</span></li>
<li>generators/fictionbook/generator_fb.cpp <span style="color: grey">(c5d5dddeb70ea66ff6276855e4163453d9823a16)</span></li>
<li>generators/fictionbook/libokularGenerator_fb.desktop <span style="color: grey">(ee51e8f0003dc1182684353eb79f8f2de69206b8)</span></li>
<li>generators/fictionbook/libokularGenerator_fb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fictionbook/okularFb.desktop <span style="color: grey">(998b22486837578c409c7ed7a3534480348415c4)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: grey">(5d9011b02ae76daac6b98e390b13857837dd9bc4)</span></li>
<li>generators/kimgio/generator_kimgio.cpp <span style="color: grey">(84c155b5ad8da5057a28faaffa417ecb60a64ab3)</span></li>
<li>generators/kimgio/libokularGenerator_kimgio.desktop <span style="color: grey">(ea483428613943fb3bc0e0535280d4e98c196b68)</span></li>
<li>generators/kimgio/libokularGenerator_kimgio.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/okularKimgio.desktop <span style="color: grey">(983c300cb2ad019c9c98b74d896ae28fb01def2a)</span></li>
<li>generators/mobipocket/CMakeLists.txt <span style="color: grey">(e826c132a03d46532ffdc866c688906915cf6d55)</span></li>
<li>generators/mobipocket/generator_mobi.cpp <span style="color: grey">(a11d2c508c840e7b94430638fe1138c216b41fed)</span></li>
<li>generators/mobipocket/libokularGenerator_mobi.desktop <span style="color: grey">(13a13600e976a2d617d7fb83f03ddeee4d91b738)</span></li>
<li>generators/mobipocket/libokularGenerator_mobi.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/mobipocket/okularMobi.desktop <span style="color: grey">(5a50a33d4c709a26703c9b24be033bdb3ab0419f)</span></li>
<li>generators/ooo/CMakeLists.txt <span style="color: grey">(eb6f63ca00c898c437c40c68466795b2b8f70f64)</span></li>
<li>generators/ooo/generator_ooo.cpp <span style="color: grey">(23708c8d9e7f8653c13d96c76d9046f93154ac48)</span></li>
<li>generators/ooo/libokularGenerator_ooo.desktop <span style="color: grey">(d769da3d8c94c7035c31cf1469792c82064baede)</span></li>
<li>generators/ooo/libokularGenerator_ooo.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/ooo/okularOoo.desktop <span style="color: grey">(f319c8c7aad44ede0228c12461c009184ff77bfc)</span></li>
<li>generators/plucker/CMakeLists.txt <span style="color: grey">(9f1f61abaebc2f864bc4e1d5e1c41fb713a6cb1c)</span></li>
<li>generators/plucker/generator_plucker.cpp <span style="color: grey">(6850036f79664ac1554e6055ebc36253ac21b0b0)</span></li>
<li>generators/plucker/libokularGenerator_plucker.desktop <span style="color: grey">(24756b323ffea2d8c2d0a478f545a00af5be8eda)</span></li>
<li>generators/plucker/libokularGenerator_plucker.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/plucker/okularPlucker.desktop <span style="color: grey">(17c5704d2c34eddf7be27d3e81a9c115fa5377df)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: grey">(a696ffbb8218abb8094afbc0db1b249bc2d9c3c8)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(90db80a41ecef76733ab79ebc41c162725cf30ed)</span></li>
<li>generators/poppler/libokularGenerator_poppler.desktop <span style="color: grey">(7b7c778380742f55bcc584d9576ff93d2acb5a9f)</span></li>
<li>generators/poppler/libokularGenerator_poppler.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/poppler/okularPoppler.desktop <span style="color: grey">(a1ef1d8aa270e3b543fdb35e776b48abc7e05de8)</span></li>
<li>generators/spectre/CMakeLists.txt <span style="color: grey">(d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1)</span></li>
<li>generators/spectre/generator_ghostview.cpp <span style="color: grey">(e2275af8911ccdf49da3df51692a83f5ba4628ed)</span></li>
<li>generators/spectre/libokularGenerator_ghostview.desktop <span style="color: grey">(552459d07928a0397b2b5d7f21ea510241ae3ff0)</span></li>
<li>generators/spectre/libokularGenerator_ghostview.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/spectre/okularGhostview.desktop <span style="color: grey">(d5bd725d3e0fbad2517f13e83499764000adf1e9)</span></li>
<li>generators/tiff/CMakeLists.txt <span style="color: grey">(89603085fef5fdfd135f04e1d4f0026772a663b0)</span></li>
<li>generators/tiff/generator_tiff.cpp <span style="color: grey">(cf4f2762a506a07288bb6fb1169ddbceb5a5eccb)</span></li>
<li>generators/tiff/libokularGenerator_tiff.desktop <span style="color: grey">(8ca968f655a4b42090e1944354b6981788319854)</span></li>
<li>generators/tiff/libokularGenerator_tiff.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/tiff/okularTiff.desktop <span style="color: grey">(cfc2b3943fc2c5bb93fac3c26ed75267234135ae)</span></li>
<li>generators/txt/CMakeLists.txt <span style="color: grey">(b095f29e9dc2aa49ec851fdd678d55bd723f1948)</span></li>
<li>generators/txt/generator_txt.cpp <span style="color: grey">(cffe8473012768c86c55263a1a65eb2ae358b7ec)</span></li>
<li>generators/txt/libokularGenerator_txt.desktop <span style="color: grey">(df6b0623aee49a644a490827cd755bac1e3a39ca)</span></li>
<li>generators/txt/libokularGenerator_txt.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/okularTxt.desktop <span style="color: grey">(e9dda9f695c474c9176a8b32b3bffcc1519222ac)</span></li>
<li>generators/xps/CMakeLists.txt <span style="color: grey">(1430bda1dd03229930fbc866ee87d277e0c2bba9)</span></li>
<li>generators/xps/generator_xps.cpp <span style="color: grey">(58bf0f638a70b07514570b4e4502bdc82f6378c7)</span></li>
<li>generators/xps/libokularGenerator_xps.desktop <span style="color: grey">(173ba72ffe47a4834c5e125b32b969a4c6fac2d3)</span></li>
<li>generators/xps/libokularGenerator_xps.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/xps/okularXps.desktop <span style="color: grey">(2e5a2c47cb50180edd22d2ec8b910d8708b854c2)</span></li>
<li>part.cpp <span style="color: grey">(ab11a25605c623c20a7c3da5a642df993f9c1859)</span></li>
<li>ui/fileprinterpreview.cpp <span style="color: grey">(70fd941b03c30b1a9f34ad12a2ee018d37172fff)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>