<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126193/">https://git.reviewboard.kde.org/r/126193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On novembre 30th, 2015, 9:35 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126193/diff/1/?file=420070#file420070line32" style="color: black; font-weight: bold; text-decoration: underline;">generators/chm/generator_chm.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="n">KAboutData</span> <span class="nf">createAboutData</span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">OKULAR_EXPORT_PLUGIN</span><span class="p">(</span><span class="n">CHMGenerator</span><span class="p">,</span> <span class="s">"libokularGenerator_chmlib.json"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why have you decided to remove the createAboutData methods? We're losing functionality and it's not a required change, no?</p></pre>
</blockquote>
<p>On desembre 1st, 2015, 1:11 a.m. UTC, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">They are no longer used in KF5 (K_EXPORT_PLUGIN is a noop) and the information there is in the JSON file now</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where losing the copyright line and the translated names, no?</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On novembre 28th, 2015, 7:28 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated nov. 28, 2015, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two commits:</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port to new JSON plugin loading system</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This means Okular can now work without ksycoca and KDELibs4Support.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bring back the about backend dialog</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unit tests still pass, opening files works</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/plucker/libokularGenerator_plucker.desktop <span style="color: grey">(24756b323ffea2d8c2d0a478f545a00af5be8eda)</span></li>
<li>ui/fileprinterpreview.cpp <span style="color: grey">(47035d63e2d46118eb5247a42d0ccdfacbb79767)</span></li>
<li>part.cpp <span style="color: grey">(d8f1750f33a903c1734857042b601b52d8d8e1f2)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: grey">(875a5cd583beb7f5457d74b153f5e942b33e4918)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(a65487af06a221cf7faf72e108aa1f04e1b91b04)</span></li>
<li>generators/poppler/libokularGenerator_poppler.desktop <span style="color: grey">(7b7c778380742f55bcc584d9576ff93d2acb5a9f)</span></li>
<li>generators/poppler/libokularGenerator_poppler.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/poppler/okularPoppler.desktop <span style="color: grey">(a1ef1d8aa270e3b543fdb35e776b48abc7e05de8)</span></li>
<li>generators/spectre/CMakeLists.txt <span style="color: grey">(617047a7c480096e05c329e421283450712b8bef)</span></li>
<li>generators/spectre/generator_ghostview.cpp <span style="color: grey">(b84e1e4e9d3d05d065b3e4e0ebd5fabbf6343c3e)</span></li>
<li>generators/spectre/libokularGenerator_ghostview.desktop <span style="color: grey">(552459d07928a0397b2b5d7f21ea510241ae3ff0)</span></li>
<li>generators/spectre/libokularGenerator_ghostview.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/libokularGenerator_txt.desktop <span style="color: grey">(df6b0623aee49a644a490827cd755bac1e3a39ca)</span></li>
<li>generators/mobipocket/okularMobi.desktop <span style="color: grey">(5a50a33d4c709a26703c9b24be033bdb3ab0419f)</span></li>
<li>generators/ooo/CMakeLists.txt <span style="color: grey">(5d11daf24cb6e4c04448be856877130e72052f10)</span></li>
<li>generators/ooo/generator_ooo.cpp <span style="color: grey">(078173060c9805f876acad5716669c9a76373740)</span></li>
<li>generators/ooo/libokularGenerator_ooo.desktop <span style="color: grey">(d769da3d8c94c7035c31cf1469792c82064baede)</span></li>
<li>generators/ooo/okularOoo.desktop <span style="color: grey">(f319c8c7aad44ede0228c12461c009184ff77bfc)</span></li>
<li>generators/ooo/libokularGenerator_ooo.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/plucker/CMakeLists.txt <span style="color: grey">(c37646764818e9147516c696a7320c427636f6f6)</span></li>
<li>generators/plucker/generator_plucker.cpp <span style="color: grey">(3a91ae7c2dceef0e168c6d3856876b8ae2d5c6d1)</span></li>
<li>generators/plucker/libokularGenerator_plucker.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/plucker/okularPlucker.desktop <span style="color: grey">(17c5704d2c34eddf7be27d3e81a9c115fa5377df)</span></li>
<li>generators/spectre/okularGhostview.desktop <span style="color: grey">(d5bd725d3e0fbad2517f13e83499764000adf1e9)</span></li>
<li>generators/tiff/CMakeLists.txt <span style="color: grey">(bab056f16a097e804b9ec8dfda295d4a745bd5b9)</span></li>
<li>generators/tiff/generator_tiff.cpp <span style="color: grey">(31b2e3e09322196c3a36698ebf457b224a34d90f)</span></li>
<li>generators/tiff/libokularGenerator_tiff.desktop <span style="color: grey">(8ca968f655a4b42090e1944354b6981788319854)</span></li>
<li>generators/tiff/libokularGenerator_tiff.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/tiff/okularTiff.desktop <span style="color: grey">(cfc2b3943fc2c5bb93fac3c26ed75267234135ae)</span></li>
<li>generators/txt/generator_txt.cpp <span style="color: grey">(8c3d2f60ebf12accd87ebfe1630d74e2dfd484ee)</span></li>
<li>generators/txt/CMakeLists.txt <span style="color: grey">(faae13a479bb80e507ed8e657ff66d51e391666f)</span></li>
<li>generators/txt/libokularGenerator_txt.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/okularTxt.desktop <span style="color: grey">(e9dda9f695c474c9176a8b32b3bffcc1519222ac)</span></li>
<li>generators/xps/CMakeLists.txt <span style="color: grey">(6bd8e58488d929ffc6f8a0cd16ef8fd2fa238587)</span></li>
<li>generators/xps/generator_xps.cpp <span style="color: grey">(d86dbcb6e0f86f582208cc4110b4980ee28e8c66)</span></li>
<li>generators/xps/libokularGenerator_xps.desktop <span style="color: grey">(173ba72ffe47a4834c5e125b32b969a4c6fac2d3)</span></li>
<li>generators/xps/libokularGenerator_xps.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/xps/okularXps.desktop <span style="color: grey">(2e5a2c47cb50180edd22d2ec8b910d8708b854c2)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d0b180e08085c58100c84a259de7528159c8a532)</span></li>
<li>core/document.h <span style="color: grey">(63f58741bd6680a673945a7b7c05a10130968beb)</span></li>
<li>generators/mobipocket/libokularGenerator_mobi.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/mobipocket/libokularGenerator_mobi.desktop <span style="color: grey">(13a13600e976a2d617d7fb83f03ddeee4d91b738)</span></li>
<li>generators/mobipocket/generator_mobi.cpp <span style="color: grey">(3040745d1b2595d005a543d0cd2c9ecde8d53902)</span></li>
<li>generators/mobipocket/CMakeLists.txt <span style="color: grey">(910623b68ebcf60a07ebaad6d6fd554b816934f5)</span></li>
<li>generators/kimgio/okularKimgio.desktop <span style="color: grey">(983c300cb2ad019c9c98b74d896ae28fb01def2a)</span></li>
<li>generators/kimgio/libokularGenerator_kimgio.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/libokularGenerator_kimgio.desktop <span style="color: grey">(ea483428613943fb3bc0e0535280d4e98c196b68)</span></li>
<li>generators/kimgio/generator_kimgio.cpp <span style="color: grey">(5dc9011e454e66965062baf0453bae7c6822d047)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: grey">(5c46af8001826c7b66d8dda273a94f9c260f2d7c)</span></li>
<li>generators/fictionbook/okularFb.desktop <span style="color: grey">(998b22486837578c409c7ed7a3534480348415c4)</span></li>
<li>generators/fictionbook/libokularGenerator_fb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fictionbook/libokularGenerator_fb.desktop <span style="color: grey">(ee51e8f0003dc1182684353eb79f8f2de69206b8)</span></li>
<li>generators/fictionbook/generator_fb.cpp <span style="color: grey">(34fcd0536dd259f64eaf95bcd0c5082bcac426ad)</span></li>
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(108568b6decdf804ba579a6dc8c81ad01a006214)</span></li>
<li>generators/fax/okularFax.desktop <span style="color: grey">(8b86b91ed02b6e15547686e2f9a589f80516ce84)</span></li>
<li>generators/fax/libokularGenerator_fax.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fax/libokularGenerator_fax.desktop <span style="color: grey">(fcffa707b157a91f84a43a8c6e8ac5b93363fef9)</span></li>
<li>generators/fax/generator_fax.cpp <span style="color: grey">(078f18cb103e6c6bc6c59aa490227b67f0d2445c)</span></li>
<li>generators/fax/CMakeLists.txt <span style="color: grey">(f3a321c9039163558c91f1b417be2ca6ed7695d0)</span></li>
<li>generators/epub/okularEPub.desktop <span style="color: grey">(2da8c9097f1764aaee675a183b4d4eb4586d44b1)</span></li>
<li>generators/epub/libokularGenerator_epub.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/epub/libokularGenerator_epub.desktop <span style="color: grey">(14d64159fd2e51ce91de3abde3cb0380c9ffe0c8)</span></li>
<li>generators/epub/generator_epub.cpp <span style="color: grey">(48e73148940bfb62b5e371366de31c9b8d961d4c)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(fa989ad88a04f3f403eb5eb51ba6faff4cb992a2)</span></li>
<li>generators/dvi/okularDvi.desktop <span style="color: grey">(5c7d3a96021a887171a6d98f0693ad88bc967f29)</span></li>
<li>generators/dvi/libokularGenerator_dvi.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/dvi/libokularGenerator_dvi.desktop <span style="color: grey">(39edcfadf8fb0273c7b7f1bde2912566db605c61)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(d1536cc038e5d957cd1ad1d3e18d2578511db929)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: grey">(e95c9ca09b469db6c33be78dd332f27f0ec1bbd5)</span></li>
<li>generators/djvu/okularDjvu.desktop <span style="color: grey">(1c2fd43b63f071f9d726e1a605681d32bc93d25f)</span></li>
<li>generators/djvu/libokularGenerator_djvu.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/djvu/libokularGenerator_djvu.desktop <span style="color: grey">(887377998ce55802cd505c42e359919cb814d615)</span></li>
<li>generators/djvu/generator_djvu.cpp <span style="color: grey">(b01175983b7f34391d4e5b2765e50340cb52722b)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: grey">(8ca545c5a43d71108b08521d625d1b76facd69da)</span></li>
<li>generators/comicbook/okularComicbook.desktop <span style="color: grey">(1dded78f4245d2770f1431f7e02123c2fa681ac9)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.desktop <span style="color: grey">(5a91a5fdd053819d75d28f93de152b9c904f41ff)</span></li>
<li>generators/comicbook/generator_comicbook.cpp <span style="color: grey">(a0d03fad112b3f251ddf6a0cc7408134b36a2988)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(4df23a679f27468fc1d06425b8006c0a02e0f202)</span></li>
<li>generators/chm/okularChm.desktop <span style="color: grey">(ed42bc25c87ee1fafe1a729d3f14f1c75e5784dd)</span></li>
<li>generators/chm/libokularGenerator_chmlib.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/chm/libokularGenerator_chmlib.desktop <span style="color: grey">(dc3ac9308fc2447f3b11f96c5618058ca95832fc)</span></li>
<li>core/document.cpp <span style="color: grey">(6953b1fb0dc29a375be7ff331a2a2bccce975366)</span></li>
<li>core/document_p.h <span style="color: grey">(fda23275033645ea67f5ad9d27341fc4635ede34)</span></li>
<li>core/generator.h <span style="color: grey">(68a7f1477deb3e44c3ff78e3c909a90082b6b8cd)</span></li>
<li>generators/CMakeLists.txt <span style="color: grey">(99ff78d32a02fc0bdf7fca8092db46f893774ed0)</span></li>
<li>generators/chm/CMakeLists.txt <span style="color: grey">(e54affca31ba18e0a0be894897a7c490a0d093c3)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(fbdcea8e9dbf7a21a72ad6b5c9d2f7724f7c6330)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>