<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125329/">https://git.reviewboard.kde.org/r/125329/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Arseniy Lartsev.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2015, 7:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch makes okular's presentation mode correctly handle PDFs that contain non-integer durations for transition effects.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Importantly, transitions less than one second long become, in principle, possible. That might still not work with some effects due to performance issues, but with #125310, the fade transition (which is, arguably, by far the most important one) should be fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works for me with both older and newest poppler</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(6389a62)</span></li>
<li>core/pagetransition.h <span style="color: grey">(4b6e7f9)</span></li>
<li>core/pagetransition.cpp <span style="color: grey">(d57106d)</span></li>
<li>generators/poppler/config-okular-poppler.h.cmake <span style="color: grey">(1e8ff9e)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(b260da3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125329/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/27/3a377ec7-2ecf-4e50-90de-05247af1f6c9__short_transition.pdf">Test case (2 slides, 0.3 s long fade transition)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>