<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124964/">https://git.reviewboard.kde.org/r/124964/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Jake Linder.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2015, 7:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=351889">351889</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ensure pixmap of proper resolution used when switching viewmode / rotating view</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Steps to repro (viewmode):
1) resize app window to be narrow enough so that in facing pages viewmode
page dimensions are reduced.
2) switch to facing pages mode.
3) switch back to single page mode.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Steps to repro (rotation):
1) open a pdf with protrait mode paper dimensions.
2) rotate the view clockwise.
3) rotate the view back to original orientation.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Expected Result:
Single page is shown at proper resolution</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actual Result:
Single page is displayed with proper dimensions but is actually a scaled-up
version of a lower resolution pixmap.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've verified that this fixes the issue.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that adding this line after slotRelayoutPages() is sprinkled
all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(27a88ddfec18d9259e669eb2ab7b60ef03e2af75)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(332eafb7da83f778501ef63c4a607f7568ed7713)</span></li>
<li>core/document.cpp <span style="color: grey">(85fe007866e77bc99ac0746a6c53b5c92ab73f67)</span></li>
<li>part-viewermode.rc <span style="color: grey">(bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7)</span></li>
<li>part.rc <span style="color: grey">(60f86e5bae0ef235093711ba10be5eb3f30e7b36)</span></li>
<li>ui/pageview.h <span style="color: grey">(e65b57500d12ae2d8c5286e6542504e17813668c)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(5e7fc29178b364bc91be7ab77f30e6e32ae731f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124964/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>