<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124687/">https://git.reviewboard.kde.org/r/124687/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid and Laurent Montel.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2015, 6:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This updated patch includes the following changes
- drawing tools don't have a name anymore, just color, pen width and opacity
- the drawing tools configuration dialog just shows a list of colored rectangles now (including black frame)
- the tooltip of the drawing tool selection buttons in presentation view has been changed to 'Toggle Drawing Tool:\n color: ...\n pen width: ...\n opacity: ...'
- the drawing tool selection buttons can now be activated via Ctrl+1 ...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extend the configuration dialog to allow defining multiple pens,
that can be used for drawing on pages in presentation mode.
Replace the pen toggle button in presentation mode top bar with
a select action, to quickly switch between the various pens.
FEATURE: 345269</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually with Okular</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(27a88ddfec18d9259e669eb2ab7b60ef03e2af75)</span></li>
<li>conf/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/autotests/editdrawingtooldialogtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/autotests/editdrawingtooldialogtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/dlgpresentation.cpp <span style="color: grey">(6c68f1e2e16f72a4723a48e331f161d27d068b00)</span></li>
<li>conf/dlgpresentationbase.ui <span style="color: grey">(78f47f7a8c8e4d74c78b562d7bfd0732f8fa5803)</span></li>
<li>conf/editannottooldialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editannottooldialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editdrawingtooldialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editdrawingtooldialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(332eafb7da83f778501ef63c4a607f7568ed7713)</span></li>
<li>conf/widgetannottools.h <span style="color: grey">(f15aa1c4f02293b45c30c309ceeb78b54b27674f)</span></li>
<li>conf/widgetannottools.cpp <span style="color: grey">(6d05eed8bbd4a6f49f54b406ad98f9a10905b7b7)</span></li>
<li>conf/widgetconfigurationtoolsbase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetconfigurationtoolsbase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetdrawingtools.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetdrawingtools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>part.cpp <span style="color: grey">(d461ebefe9533eefdcf918eb153826479e034476)</span></li>
<li>ui/annotationtools.h <span style="color: grey">(dc36dc7c08778e427636bb9d0454c27ca59f6877)</span></li>
<li>ui/annotationtools.cpp <span style="color: grey">(afc71764fd8f82d67fa7f56ce99cf8f4f8c3a64b)</span></li>
<li>ui/data/CMakeLists.txt <span style="color: grey">(491b9935760d0fa81d46b6007f7f44e5e679156b)</span></li>
<li>ui/data/drawingtools.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/drawingtoolselectaction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/drawingtoolselectaction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/presentationwidget.h <span style="color: grey">(81beb6c53b9232b409efc3a1f2bd8fb5575b492b)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(0d9a55dc236a016f6808261bc95f8286f9cfa2ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>