<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124612/">https://git.reviewboard.kde.org/r/124612/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid and Laurent Montel.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2015, 9:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed @since tag, extended FindPoppler.cmake to discover poppler-qt5 in version 0.35, fixed HAVE_POPPLER checks to test for HAVE_POPPLER_0_35</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=326230">https://bugs.kde.org/show_bug.cgi?id=326230</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch adds basic support for RichMedia annotations in PDF files. The Media9 LaTeX package includes a Flash player and the actual video file as embedded files into the PDF. This patch parses the parameters, which are passed to the Flash player, extracts the referenced video file and uses the normal video player for playback.
Note: This patch requires a poppler version that has the two patches https://bugs.freedesktop.org/show_bug.cgi?id=91547 and https://bugs.freedesktop.org/show_bug.cgi?id=91548 included. Therefor this patch is marked as WIP for the moment.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with the PDF file that is attached to Bug 326230.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(6389a625d3ba4de5d12378a920c1576a1b505903)</span></li>
<li>core/annotations.h <span style="color: grey">(4f107440dc824fd9049a30082befd18642e63895)</span></li>
<li>core/annotations.cpp <span style="color: grey">(e02994688414bdf485b308d6ef122ee2eff3fbaf)</span></li>
<li>generators/poppler/annots.cpp <span style="color: grey">(8cde64833831ec833b3be552608cff99d38f8e63)</span></li>
<li>generators/poppler/config-okular-poppler.h.cmake <span style="color: grey">(1e8ff9ed34164b1fcd42b504541e38241c59efa4)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(07abf75c2f530cfa275b797fc9287167df5a4a8c)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(5e7fc29178b364bc91be7ab77f30e6e32ae731f7)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(0d9a55dc236a016f6808261bc95f8286f9cfa2ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124612/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>