<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124687/">https://git.reviewboard.kde.org/r/124687/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 10th, 2015, 9:23 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's the difference between this and https://git.reviewboard.kde.org/r/124614/ ?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Laurent's patch doesn't apply cleanly to framework HEAD anymore... but Laurent is on vacation, so I had to push a new patch (since I'm not allowed to modify Laurent's patch directly).</pre>
<br />
<p>- Tobias</p>
<br />
<p>On August 10th, 2015, 11:38 a.m. UTC, Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid and Laurent Montel.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2015, 11:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extend the configuration dialog to allow defining multiple pens,
that can be used for drawing on pages in presentation mode.
Replace the pen toggle button in presentation mode top bar with
a select action, to quickly switch between the various pens.
FEATURE: 345269</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually with Okular</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(27a88ddfec18d9259e669eb2ab7b60ef03e2af75)</span></li>
<li>conf/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/autotests/editquickselectiontooldialogtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/autotests/editquickselectiontooldialogtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/dlgpresentation.cpp <span style="color: grey">(6c68f1e2e16f72a4723a48e331f161d27d068b00)</span></li>
<li>conf/dlgpresentationbase.ui <span style="color: grey">(78f47f7a8c8e4d74c78b562d7bfd0732f8fa5803)</span></li>
<li>conf/editannottooldialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editannottooldialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editquickselectiontooldialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/editquickselectiontooldialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(332eafb7da83f778501ef63c4a607f7568ed7713)</span></li>
<li>conf/widgetannottools.h <span style="color: grey">(f15aa1c4f02293b45c30c309ceeb78b54b27674f)</span></li>
<li>conf/widgetannottools.cpp <span style="color: grey">(6d05eed8bbd4a6f49f54b406ad98f9a10905b7b7)</span></li>
<li>conf/widgetconfigurationtoolsbase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetconfigurationtoolsbase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetquickselectiontools.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/widgetquickselectiontools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>part.cpp <span style="color: grey">(d461ebefe9533eefdcf918eb153826479e034476)</span></li>
<li>ui/data/CMakeLists.txt <span style="color: grey">(491b9935760d0fa81d46b6007f7f44e5e679156b)</span></li>
<li>ui/data/quickselectiontools.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/presentationwidget.h <span style="color: grey">(81beb6c53b9232b409efc3a1f2bd8fb5575b492b)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(0d9a55dc236a016f6808261bc95f8286f9cfa2ec)</span></li>
<li>ui/quickselectiontoolselectaction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/quickselectiontoolselectaction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>