<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124026/">https://git.reviewboard.kde.org/r/124026/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 9th, 2015, 9:20 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why are you removing the test? Seems like a value test to me to make sure we're differentiating when # is a char of the file and when # refers to a page number.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because that test always fails right now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wasn't aware of the #page convention. I'll be happy if the test was fixed instead of course. Feel free to reject this patch.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On June 8th, 2015, 8:59 a.m. UTC, Jan Kundrát wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jan Kundrát.</div>
<p style="color: grey;"><i>Updated June 8, 2015, 8:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When this test was written, converting from user-supplied strings to
URLs with support for guessing whether the URL represents a local file
(but only if it exists) or a remote URL was something not provided by
Qt. That has changed in Qt 5.4, and what we have now is a unit test
which is too stupid because it blindly concatenates cwd with a
user-provided input.
My understanding is that pre-5.4 Qt is supported on a best-effort basis,
and that there's little point it carrying unit tests which only
duplicate Qt's native features. Especially when these unit tests fail.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have no idea whether this introduces any regressions. There's plenty of test failures, both on the official KDE CI platform <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">and</em> on my local dev box. How do I, for example, persuade the KService/whatever to ignore the systemwide installation of Okular and to use, e.g., poppler generator from the build directory?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/shelltest.cpp <span style="color: grey">(0f750ae1f816e523f1bfaa8c19b9c947f0d0f8f3)</span></li>
<li>shell/okular_main.cpp <span style="color: grey">(b66b6a5f7cd30e6d123ba0b0a2d871e11807ea15)</span></li>
<li>shell/shellutils.h <span style="color: grey">(d5518c344c47dd81033a883cc43cca387764d362)</span></li>
<li>shell/shellutils.cpp <span style="color: grey">(0dd737cf70ac888225a919799bd71905cfb89580)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>