<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123466/">https://git.reviewboard.kde.org/r/123466/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2015, 12:07 a.m. BST, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just build the frameworks branch and the pdf generator was loaded just fine, are you sure this is needed?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, it works because there is a workaround applied in document.cpp (create QObject instead of Okular::Generator and then use dynamic_cast). This patch removes the need for that workaround and adds a unit test that all generators can be loaded without the workaround.</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On April 22nd, 2015, 2:09 p.m. BST, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated April 22, 2015, 2:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This seems to be required with KPluginFactory and Qt5 since without it
KPluginFactory::create<Okular::Generator>() always returns null.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For some reason this requires a complete rebuild before generatorstest
passes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also add a test to see that generators can be loaded</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loading didn't work before, does not. Requires a full rebuild.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/djvu/generator_djvu.h <span style="color: grey">(f056fecf3d7831e34693f822c2cd9dc40ccf4c78)</span></li>
<li>generators/comicbook/generator_comicbook.h <span style="color: grey">(a521abb7d4ba1f1fbab7f102c9849221bea35019)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(e9f2a8e8f69a1d7592cdfdaf6fb5bdc91d0d2ca2)</span></li>
<li>core/document.cpp <span style="color: grey">(2d4e85d86bb338226b8870ff8be1c790be9a937b)</span></li>
<li>autotests/generatorstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(0a0f546203536f65a5b6c72f81c05c58809216ce)</span></li>
<li>generators/dvi/generator_dvi.h <span style="color: grey">(1fac6b3651bc76c17ed15b2b821553c15534e85b)</span></li>
<li>generators/epub/generator_epub.h <span style="color: grey">(3da0191e4074c876805f9c39d2473d7f4f7ce161)</span></li>
<li>generators/fax/generator_fax.h <span style="color: grey">(66d83c81733b20db8493dba56ea56f4f13f98eca)</span></li>
<li>generators/fictionbook/generator_fb.h <span style="color: grey">(fc6dc95a4d6d439d2eae84428c5db8243fc548be)</span></li>
<li>generators/kimgio/generator_kimgio.h <span style="color: grey">(feb642c4707d14a7eed1fe7fe6024cc7adf9e09d)</span></li>
<li>generators/mobipocket/generator_mobi.h <span style="color: grey">(70c3150d34856283a7acd0cb735f9f4ac576de56)</span></li>
<li>generators/ooo/generator_ooo.h <span style="color: grey">(2bfa81c9c07d8de0e7d81e790aea749c43475b9a)</span></li>
<li>generators/plucker/generator_plucker.h <span style="color: grey">(ff96fbbfce86cb01d02a895fa1f937df366a33bd)</span></li>
<li>generators/poppler/generator_pdf.h <span style="color: grey">(f3226b2684846b38ca99839a07a7f8cfb7c618a1)</span></li>
<li>generators/spectre/generator_ghostview.h <span style="color: grey">(914a51810aca376c76efe3ba153bafef427e3972)</span></li>
<li>generators/tiff/generator_tiff.h <span style="color: grey">(e2d0d544d0618748bfe85997a1e3ea7c1938dd84)</span></li>
<li>generators/txt/generator_txt.h <span style="color: grey">(9a972c07e1f7e66f36a3c69f9ddd923f6a2fa72b)</span></li>
<li>generators/xps/generator_xps.h <span style="color: grey">(af8d3373afc2aa8d4d6bd407ab0f3b5b94e07bf6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>