<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123314/">https://git.reviewboard.kde.org/r/123314/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Квітень 14th, 2015, 10:34 після полудня CEST, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this I can build Kile, so I'd say Ship it</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can't. My changes to test Kile are the following: http://pastebin.com/HMv9Ziku. And GCC says:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">In file included from ..<span style="color: #666666">/</span>..<span style="color: #666666">/</span>src<span style="color: #666666">/</span>kileviewmanager.<span style="color: #A0A000">cpp</span>:<span style="color: #666666">62:0:</span>
<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>okular<span style="color: #666666">/</span>interfaces<span style="color: #666666">/</span>viewerinterface.<span style="color: #A0A000">h</span>:<span style="color: #666666">13:31:</span> fatal <span style="color: #A0A000">error</span>: okularcore_export.<span style="color: #A0A000">h</span>: No such file or directory
<span style="color: #BC7A00">#include "okularcore_export.h"</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pephaps Okular::okularcore target should add path to its headers (/usr/include/okular/core/) to include_directories?</p></pre>
<br />
<p>- Eugene</p>
<br />
<p>On Квітень 14th, 2015, 9:48 після полудня CEST, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Квітень 14, 2015, 9:48 після полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing on a Debian system</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Eugene: does it fix the regression for you?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(56c9976)</span></li>
<li>OkularConfig.cmake <span style="color: grey">(171b845)</span></li>
<li>OkularConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/version.h <span style="color: grey">(855df95)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>