<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123314/">https://git.reviewboard.kde.org/r/123314/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I cann't say that it fixes the issue. Maybe it does, but I just can not make it working.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm testing with Kile. Kile needs access to okular/interfaces/viewerinterface.h. However, this file contains <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#include "okularcore_export.h"</code>. Thus, path to Okular includes is needed. But OKULAR_INCLUDE_DIR is gone. OK, let's try to do this in the new way. So I add KF5::okularcore target to the dependencies (BTW, why KF5?). But have you seen its INTERFACE_LINK_LIBRARIES property? KF5::Archive;KF5::JS;KF5::JSApi;KF5::KDELibs4Support;KF5::KIOCore;KF5::ThreadWeaver;KF5::Wallet;Phonon::phonon4qt5;m;/usr/lib64/libz.so. Are all of them indeed needed just to link with Okular?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, what am I doing wrong?</p></pre>
<br />
<p>- Eugene Shalygin</p>
<br />
<p>On Квітень 10th, 2015, 6:14 після полудня CEST, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Квітень 10, 2015, 6:14 після полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing on a Debian system</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Eugene: does it fix the regression for you?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(56c9976)</span></li>
<li>OkularConfig.cmake <span style="color: grey">(171b845)</span></li>
<li>OkularConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/version.h <span style="color: grey">(855df95)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>