<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120311/">https://git.reviewboard.kde.org/r/120311/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The testing I performed on a bunch of pdf and dvi files does not show evident regressions.
If I read correctly we need also to bump the libokularcode version.</p></pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On settembre 22nd, 2014, 12:22 a.m. CEST, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Set. 22, 2014, 12:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This way dvi and any other potential user gets it for free</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The diff is huge, but the synctex files are just moves.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And the code in core/ is also mostly just a move from the generator_pdf.cpp code</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Played with the instructions of https://bugs.kde.org/show_bug.cgi?id=326605#c19</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both latex and pdflatex synctex work now</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">latex -src-specials also still works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/poppler/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff <span style="color: grey">(4e09637)</span></li>
<li>generators/poppler/synctex/patches/08-fix_cpp_comments.diff <span style="color: grey">(90413b4)</span></li>
<li>generators/poppler/synctex/patches/09-fix_path_comparison.diff <span style="color: grey">(984a0a6)</span></li>
<li>generators/poppler/synctex/patches/series <span style="color: grey">(7497c52)</span></li>
<li>generators/poppler/synctex/synctex_parser.h <span style="color: grey">(4aca415)</span></li>
<li>generators/poppler/synctex/synctex_parser.c <span style="color: grey">(8244f27)</span></li>
<li>generators/poppler/synctex/synctex_parser_local.h <span style="color: grey">(6573b26)</span></li>
<li>generators/poppler/synctex/synctex_parser_readme.txt <span style="color: grey">(ebc06bb)</span></li>
<li>generators/poppler/synctex/synctex_parser_utils.h <span style="color: grey">(92184b8)</span></li>
<li>generators/poppler/synctex/synctex_parser_utils.c <span style="color: grey">(03da409)</span></li>
<li>generators/poppler/synctex/synctex_parser_version.txt <span style="color: grey">(03ff897)</span></li>
<li>generators/poppler/synctex/patches/04-gcc-specify-printf-format.diff <span style="color: grey">(7b2d796)</span></li>
<li>generators/poppler/synctex/patches/05-fix-error-formats.diff <span style="color: grey">(fad5a9e)</span></li>
<li>generators/poppler/synctex/patches/06-mingw-_synctex_error.diff <span style="color: grey">(5c838d7)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(a26c6eb)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: grey">(4849655)</span></li>
<li>generators/poppler/generator_pdf.h <span style="color: grey">(2faa0d8)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(d61b996)</span></li>
<li>generators/poppler/synctex/patches/00-disable-SYNCTEX_INLINE.diff <span style="color: grey">(a28faf1)</span></li>
<li>generators/poppler/synctex/patches/01-fix-win32-define.diff <span style="color: grey">(75b3198)</span></li>
<li>core/synctex/synctex_parser_local.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser_readme.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser_utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser_utils.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser_version.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/synctex_parser.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/08-fix_cpp_comments.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/09-fix_path_comparison.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/series <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/04-gcc-specify-printf-format.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/05-fix-error-formats.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/06-mingw-_synctex_error.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(34f9f6a)</span></li>
<li>core/document.cpp <span style="color: grey">(721d36a)</span></li>
<li>core/document_p.h <span style="color: grey">(a71912b)</span></li>
<li>core/generator.h <span style="color: grey">(2c12927)</span></li>
<li>core/generator.cpp <span style="color: grey">(e74064e)</span></li>
<li>core/synctex/patches/00-disable-SYNCTEX_INLINE.diff <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/synctex/patches/01-fix-win32-define.diff <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120311/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>