<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118293/">https://git.reviewboard.kde.org/r/118293/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated ago. 10, 2014, 8:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">DocumentInfo is now QMap based instead of XML based. Makes internal handling easier. The generators don't do any caching anymore since the Document was already doing caching, made no sense. Now we only ask for the keys we need (except the properties dialog) so the generators that are slow can decide to return only what was asked for. Some generators (i.e. unpluck, xps or the text based ones) will still return all the info since it's calculated on load time and it's not time consuming to return everything if we already have it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Opened a few files, works as it did. Added some extra debug, made sure that only the info we want is asked for, and that it's properly cached.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/xps/generator_xps.h <span style="color: grey">(4c56e8c)</span></li>
<li>generators/xps/generator_xps.cpp <span style="color: grey">(2399a96)</span></li>
<li>part.cpp <span style="color: grey">(d9f1682)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(4aaec2a)</span></li>
<li>ui/propertiesdialog.cpp <span style="color: grey">(485c2de)</span></li>
<li>generators/fax/generator_fax.h <span style="color: grey">(1cb7d22)</span></li>
<li>generators/fax/generator_fax.cpp <span style="color: grey">(38873ef)</span></li>
<li>generators/kimgio/generator_kimgio.h <span style="color: grey">(faebd85)</span></li>
<li>generators/kimgio/generator_kimgio.cpp <span style="color: grey">(f856434)</span></li>
<li>generators/plucker/generator_plucker.h <span style="color: grey">(8dac4b8)</span></li>
<li>generators/plucker/generator_plucker.cpp <span style="color: grey">(4ffdead)</span></li>
<li>generators/poppler/generator_pdf.h <span style="color: grey">(1a34bb7)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(c978b09)</span></li>
<li>generators/spectre/generator_ghostview.h <span style="color: grey">(ab9c33d)</span></li>
<li>generators/spectre/generator_ghostview.cpp <span style="color: grey">(7b0146a)</span></li>
<li>generators/tiff/generator_tiff.h <span style="color: grey">(9ad1de6)</span></li>
<li>generators/tiff/generator_tiff.cpp <span style="color: grey">(bc692de)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(84b9dde)</span></li>
<li>generators/djvu/generator_djvu.h <span style="color: grey">(93ee4de)</span></li>
<li>generators/djvu/generator_djvu.cpp <span style="color: grey">(c506ce3)</span></li>
<li>generators/dvi/generator_dvi.h <span style="color: grey">(d7bf8fd)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(166a905)</span></li>
<li>core/document.h <span style="color: grey">(06bac8a)</span></li>
<li>core/document.cpp <span style="color: grey">(99e0563)</span></li>
<li>core/document_p.h <span style="color: grey">(08775da)</span></li>
<li>core/generator.h <span style="color: grey">(506f8a8)</span></li>
<li>core/generator.cpp <span style="color: grey">(ec1d1f7)</span></li>
<li>core/script/kjs_document.cpp <span style="color: grey">(c3280cd)</span></li>
<li>core/textdocumentgenerator.h <span style="color: grey">(ec331d6)</span></li>
<li>core/textdocumentgenerator.cpp <span style="color: grey">(d598ccc)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(5d97009)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118293/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>