<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118950/">https://git.reviewboard.kde.org/r/118950/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same as with Review 119133: What about just using qAbs instead of std::abs?</p></pre>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Juli 9th, 2014, 3:57 nachm. UTC, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular, Jon Mease, Luigi Toscano, and Tingnan Zhang.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Juli 9, 2014, 3:57 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both C and C++ have abs() function. C one is abs(int), declared in <stdlib.h>; and C++ has std::abs(int), std::abs(long) and std::abs(long long) in <cstdlib.h>. But C++ has even more overloaded abs() versions in <cmath>, that do operate on floating point values.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">core/utils.cpp incorrectly includes <cmath> while std::abs() calls near line 140 use integer versions really:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> <span style="color: #666666">&&</span> std::<span style="color: #A0A000">abs</span>(static_cast<span style="color: #666666"><</span>int<span style="color: #666666">></span>(selectedOutput<span style="color: #666666">-></span>edid()<span style="color: #666666">-></span><span style="color: #008000">width</span>()<span style="color: #666666">*10</span>) <span style="color: #666666">-</span> szMM.width()) <span style="color: #666666"><</span> <span style="color: #666666">10</span>
<span style="color: #666666">&&</span> std::<span style="color: #A0A000">abs</span>(static_cast<span style="color: #666666"><</span>int<span style="color: #666666">></span>(selectedOutput<span style="color: #666666">-></span>edid()<span style="color: #666666">-></span><span style="color: #008000">height</span>()<span style="color: #666666">*10</span>) <span style="color: #666666">-</span> szMM.height()) <span style="color: #666666"><</span> <span style="color: #666666">10</span>)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch changes include to <cstdlib>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on OpenBSD/i386. Without this patch, build fails.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/utils.cpp <span style="color: grey">(71442f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118950/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>