<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118236/">https://git.reviewboard.kde.org/r/118236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 24th, 2014, 2:39 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm undecided about this, i know it is something people want, but it looks extremely fragile the way stuff is saved/restored.
Do you think you could have a look and see if Qt5 offers this feature? And maybe if not implement it there? Qt5 is muuuuuuuuuch more open thatn Qt4 so implementing small features like this should not be that hard. I'll also add John Layt to the review, he's been working on Qt5 Printing stuff and maybe has time to comment a bit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I support doing it in Qt5 if you think that is better in the long run (and in that case I withdraw this review request).
Unfortunately it cannot be me who implements that in Qt5. My Qt skills are non-existent, and my time constraints don't allow me to learn it.
However, I'd be happy to send some sort of donation or a box of the famous Aachen chocolate to whoever implements it properly.</pre>
<br />
<p>- Oliver</p>
<br />
<p>On May 24th, 2014, 2:39 p.m. UTC, Oliver Sander wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and John Layt.</div>
<div>By Oliver Sander.</div>
<p style="color: grey;"><i>Updated May 24, 2014, 2:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save the okular printer settings in a config file, to make them persistent across sessions.
This is the patch submitted by user 'Hulahup' in Comment 4 of https://bugs.kde.org/show_bug.cgi?id=308367
I extended it to also store the duplex mode of the printer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Duplex mode appears to be correctly stored. Yay!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b869aec)</span></li>
<li>conf/printer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/printer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/printer.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/settings_printer.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>part.cpp <span style="color: grey">(d9f1682)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>