<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109632/">https://git.reviewboard.kde.org/r/109632/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2013, 1:06 a.m. UTC, <b>Jon Mease</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Comments on the functionality (not the implementation):
1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet PC ink document annotation).
2) How difficult would it be to add something like an "erase ink strokes" option to the tools.xml. Xournal has this option and it controls whether an ink stroke is fully deleted by the eraser (as you do for the other annotation types) or erased incrementally (your current implementation for ink annotations). I've found both of these settings to be quite helpful under different circumstances. </pre>
</blockquote>
<p>On March 24th, 2013, 7:57 a.m. UTC, <b>Peter Grasch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To do that, we would just need to *not* treat the ink annotation as a special case.
Btw, it would also be easy to add a "pen width" to the eraser by not using objectRects but nearestObjectRect (iteratively for as long as distance <= penWidth).</pre>
</blockquote>
<p>On September 25th, 2013, 8:21 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Peter how's the implementation of this going? Do you need anything from us or just time?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Peter, I'm going to discard this with the hope of maintaining a cleaner reviewboard queue. This does not mean we do not appreciate this feature. We do, so if you ever get time to work on this please create a new review request with it.
Thanks again for caring about Okular :)</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 21st, 2013, 1:26 a.m. UTC, Peter Grasch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Peter Grasch.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 1:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prerequisites: Please read till the end!
This introduces a new annotation tool: "Eraser".
The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.).
However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved.
This is what it looks like: http://bedahr.org/eraser.ogv
Example tool configuration for your tools.xml (not included in patch):
<tool id="15" name="Eraser" pixmap="tool-eraser-okular">
<tooltip>Eraser</tooltip>
<engine type="Eraser" />
<shortcut>7</shortcut>
</tool>
The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change.
I hope we can resume the discussion about possible improvements here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/pageviewannotator.cpp <span style="color: grey">(7bd7496)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>