<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113973/">https://git.reviewboard.kde.org/r/113973/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f22d9d28973713011114266e3c5d3235484a0d14 by Albert Astals Cid on behalf of Michal Humpula to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 23rd, 2014, 8:59 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 8:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
So the remaining question is, what is the status of this:
core/document_p.h:213 "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(63d2922)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(f954c9a)</span></li>
<li>part.rc <span style="color: grey">(0b9cee5)</span></li>
<li>ui/magnifierview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/magnifierview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/pageview.h <span style="color: grey">(9c15af6)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(7c7f785)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113973/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>