<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115925/">https://git.reviewboard.kde.org/r/115925/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Luigi Toscano.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reduce the number of KMessageBox for information/error and change them into signals for PageViewMessage.
The proper signals are propagated.
Few strings have been adapted or outdated information have been removed.
This is just the beginning of a series of similar cleanup. I'm posting the first one to get feedback on this solution :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Temporarily remove the dvips executable and try to print a DVI file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(c666933)</span></li>
<li>generators/dvi/psgs.h <span style="color: grey">(6842a94)</span></li>
<li>generators/dvi/psgs.cpp <span style="color: grey">(f54d78e)</span></li>
<li>generators/dvi/dviexport.cpp <span style="color: grey">(c35f4b4)</span></li>
<li>generators/dvi/dviRenderer.h <span style="color: grey">(842c11e)</span></li>
<li>generators/dvi/dviRenderer.cpp <span style="color: grey">(4513ee2)</span></li>
<li>generators/dvi/dviexport.h <span style="color: grey">(3265645)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115925/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>