<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115335/">https://git.reviewboard.kde.org/r/115335/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 9:42 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485" style="color: black; font-weight: bold; text-decoration: underline;">ui/pageview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4482</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> d->middleMouseScrollTimer->start( 20 );</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you explain why the need for a timer?</pre>
</blockquote>
<p>On January 28th, 2014, 3:47 a.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is because, in scroll mode, user just moves their mouse a little bit and then does nothing. The screen will automatically scroll until user exits scroll mode (by another mouse click).
In order to let the screen scroll duratively, you will need a timer.</pre>
</blockquote>
<p>On February 3rd, 2014, 10:17 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And this is why the whole bug makes no sense. Okular already has a way to scroll that is using the left mouse button. And now you want to make the fact that middle mouse button also scrolls but in a different way. This makes no sense at all. I'm not going to continue reviewing this unless someone explains me why Okular should have two different ways of scrolling.</pre>
</blockquote>
<p>On February 4th, 2014, 3:40 a.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not quite understand this. How can I use the left mouse to do scroll? If you mean in "Broswer" mode and use the mouse to drag the page, then I can argue that
1. Using the middle mouse is more suitable when you want to scroll a large distance. The "drag" method is not very convenient when you want to scroll more than a screen: you need to move the mouse to the bottom of the screen, drag it to the top and then repeat this until you scroll to your target. _You need move your mouse a lot_. But for middle mouse, it is relatively simpler: You do a middle click. Then you move you mouse down a little bit (the scroll speed is determined by this displacement). Then the page starts to scroll. You wait until the page scrolls to the target position and then you do another click to stop the scroll. _You do not need to move your mouse a lot and you can achieve a higher scroll speed than using left mouse's method_.
2. For people migrated from adobe reader (or Windows), they maybe more happier using middle wheel to scroll according to their habit. (Although this is short, I think this is the main reason people request this feature on the KDE Bugtracking System).
3. Using middle mouse to scroll works in all mode including the "Broswer" mode.</pre>
</blockquote>
<p>On February 4th, 2014, 9:09 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Really? Have you even tried Okular? Because you do *not* need to drag your mouse to the top...
2. Do you know of any other app that uses that totally non standard way of scrolling?
3. So?</pre>
</blockquote>
<p>On February 5th, 2014, 3:51 a.m. UTC, <b>Yichao Zhou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. I have said I do not quite understand what you mean by scroll using the left mouse button. I only know I can "drag the page", which really needs me to move my mouse up a lot if I want to scroll *a large distance down*. (Of course I can just set the page number or use the page up/down button, but that also requires me to move my mouse for viewer to toolbar, which may not be a small distance.) If I'm wrong, maybe you could described the desired behaviour of okular so I can see if I'm missing any feature.
2.
(a). Firefox, there is an option "Use autoscrolling", which enables you to use this way of scrolling.
(b). Libreoffice, I'm sure there is also a similar setting, even through middle click is important because it is a "paste" command by default, which is not a problem for Okular.
(c). Evince, the gnome's pdf reader also enable you using middle click to scroll *by default*. Although its behaviour is a bit different compared to this patch, it is at least compatible to people's habit.
What I list are the applications under Linux. Almost all the applications under Windows Operation System use this method to scroll, like Adobe reader, firefox, chrome, IE, Office and [[name any application using scroll heavily]]. Maybe it is a non standard way of scrolling under X, it is definitely the de facto scroll standard (except for using wheel) under Windows without doubt.
When I was new to okular (and Linux), the accidental resize of the document when you want to scroll is really really annoying! Although it is accpetable for me, since I'm used to use the wheel to scroll the page under Okular now. I just want to share a patch which may solve the similar problem that I have suffered!
In fact, in application such as Web Browser and Document Reader, what people mainly does is just scrolling page down! Maybe you do not really need it; maybe the code in pageview.h is in a little disorder now; but IMHO it totally is worth it!
3. So maybe it is more convenient for some people? People do not need to switch back for scroll if they want to stay, for example, at text selection mode? (I pretty like to stay at text selection mode since I can highlight the text that I'm reading.)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. You said "You need to move the mouse to the bottom of the screen, drag it to the top and then repeat", that is simply not true, you can simply just keep moving up
2.
(a) A non standard option
(b) If you can't find it, how are you sure it is there
(c) Doesn't do what this patch does (it does what our left button does)
3) The fact that we should merge browse and text selection mode is a different issue, not an excuse for introducing a weird behaviour on the middle mouse move
Now, i could accept a patch in which middle mouse button did also move as left mouse one does in browse (i.e. the same thing that evince does) if enabling an option, but i don't see the need for a feature like the one you are presenting here.</pre>
<br />
<p>- Albert</p>
<br />
<p>On February 4th, 2014, 4:39 a.m. UTC, Yichao Zhou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Yichao Zhou.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 4:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=219121">219121</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.
This patch also fixes some problems in the original patch, and provides more features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
* In scroll mode, now okular can load new page correctly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>conf/dlgaccessibilitybase.ui <span style="color: grey">(9e76a75)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(deabd07)</span></li>
<li>ui/pageview.h <span style="color: grey">(9c15af6)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(65967bf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115335/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>