<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113973/">http://git.reviewboard.kde.org/r/113973/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 27th, 2013, 9:46 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113973/diff/1/?file=215055#file215055line41" style="color: black; font-weight: bold; text-decoration: underline;">ui/magnifierview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pal</span><span class="p">.</span><span class="n">setColor</span><span class="p">(</span><span class="n">m_info</span><span class="o">-></span><span class="n">backgroundRole</span><span class="p">(),</span> <span class="n">Qt</span><span class="o">::</span><span class="n">yellow</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hardcoded colors are usually bad, there's nothing in KColorScheme you can use?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not so sure that new patch solves that. Though the color which is displayed on my desktop is usable, it's probably not the correct use of KColorScheme. The info box is more a devel box, but I could imagine that displaying current mouse location on document (maybe in mm instead) could be a good thing.</pre>
<br />
<p>- Michal</p>
<br />
<p>On November 20th, 2013, 5:53 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 5:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
So the remaining question is, what is the status of this:
core/document_p.h:213 "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(217337f)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(deabd07)</span></li>
<li>ui/magnifierview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/magnifierview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/pageview.h <span style="color: grey">(9c15af6)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(65967bf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113973/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/20/52c4f894-2286-421e-8025-45027d93524e__01-hack.patch">Allow BIG pixmaps</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>