<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114019/">http://git.reviewboard.kde.org/r/114019/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd prefer if you didn't use Phonon enum for this and used our own enum, that way if we ever want to rework the internal player to not use Phonon, there won't be a need to update the API. Also a @since marker is missing for the new method.</pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On November 22nd, 2013, 9:51 a.m. UTC, Egor Matirov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Egor Matirov.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2013, 9:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extend AudioPlayer so that it gives info about if something is playing at the moment or not according to GCI task:
- http://www.google-melange.com/gci/task/view/google/gci2013/5789010593054720</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/audioplayer.h <span style="color: grey">(7697562)</span></li>
<li>core/audioplayer.cpp <span style="color: grey">(af59588)</span></li>
<li>core/audioplayer_p.h <span style="color: grey">(c6d43cf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114019/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>