<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113978/">http://git.reviewboard.kde.org/r/113978/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113978/diff/2/?file=215099#file215099line115" style="color: black; font-weight: bold; text-decoration: underline;">core/action.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GotoAction::GotoAction( const QString& fileName, const DocumentViewport & viewport )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">106</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">m_extFileName</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_vp</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span class="o">?</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Go to page %1"</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_vp</span><span class="p">.</span><span class="n">pageNumber</span> <span class="o">+</span> <span class="mi">1</span> <span class="p">)</span> <span class="o">:</span> <span class="s">""</span> <span class="p">)</span> <span class="o">:</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">115</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">m_extFileName</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_<span class="hl">dest</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">isEmpty</span></span><span class="p"><span class="hl">()</span></span><span class="o"><span class="hl">?</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">m_</span>vp</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span class="o">?</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Go to page %1 "</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_vp</span><span class="p">.</span><span class="n">pageNumber</span> <span class="o">+</span> <span class="mi">1</span> <span class="p">)</span> <span class="o">:</span> <span class="s">""</span> <span class="p">)</span><span class="o"><span class="hl">:</span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">m_dest</span></span><span class="p"><span class="hl">)</span></span> <span class="o">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please don't use m_dest to store somethint that has nothing to do with what m_dest is about, just add another QString.</pre>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On November 20th, 2013, 7:56 p.m. UTC, Fredy BackSlash wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Fredy BackSlash.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 7:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the module FB2 small refinement to the tips to the references to footnotes, finding does footnote.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/action.h <span style="color: grey">(d089151f36d48074301b6a25fe6088959cd7771e)</span></li>
<li>core/action.cpp <span style="color: grey">(7c7b09c3eb49eaea0fd1a8242f8cf0fd95e67e0e)</span></li>
<li>generators/fictionbook/converter.cpp <span style="color: grey">(9f3ec26d3ecee702c2f8f8a041678826bab2abf5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113978/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>