<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113434/">http://git.reviewboard.kde.org/r/113434/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, the code works, so that's more than enough :-)
What i'd like though is not giving a default shortcut (i.e. remove the Ctrl+I line) so that it does not "eat" of the few precious shortcuts that are free. Of course if you are a user of this feature you can still go to the configure shortcuts and set one (or go to configure toolbars and put it on the toolbar). Would that be acceptable for you?</pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 25th, 2013, 4:02 p.m. UTC, Ciro Santilli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Ciro Santilli.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2013, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=173264">173264</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added default shortcut Ctrl + I for change colors.
This should have the exact same of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs.
I am not sure if:
- viewport()->update() is the right way to update the screen after this config change? Where is the `update()` method defined? If I tracked well, viewport() returns a DocumentViewport, which does not seem to have such a method.
- I placed the new feature in the right class
but it seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/pageview.h <span style="color: grey">(fd4e3ac)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(a1ab5bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113434/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>