<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111793/">http://git.reviewboard.kde.org/r/111793/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 4:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Fixed libkexiv2 detection (previously it didn't compile at all if missing, now it just skips the kimgio generator)
- Added autotest with images for all possible Exif Orientation values.
All images actually produce the same output (a white 3x2 rectangle, with a single black pixel in the top-left corner).
For each image, the test checks that the image gets rotated/mirrored correctly and correct pixmaps are generated.
In order to obtain pixmaps, I had to compile PagePainter from ui/ along with the test, like okular active currently does.
(If I find some time, I can try to move PagePainter into okularcore [in a separate patch, of course]. What do you think?)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322920">322920</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes bug 322920 (JPG images don't open rotated correctly).
It adds a dependency on libKExiv2, which is a wrapper around Exiv2.
I've put the code that applies the transformation in loadDocument(), which means that it will block the UI.
Of course, with a little more effort, it can be moved to image(), but I've decided to keep it in loadDocument() because:
- it's a one-time only operation;
- loadDocument() already blocks while loading the file, so I guess a little more time won't hurt much.
Of course, if you don't agree, I can change it.
The dependency on libKExiv2 *not* optional because I want to avoid having orientation depend on compilation flags. If I made it optional and you shared a .okular archive with annotations, their (normalized) coordinates would no longer be consistent among clients.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Image from bug 322920
- Images taken with my phone (Galaxy S2)
- Images without Exif metadata at all, to verify that they still work</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/CMakeLists.txt <span style="color: grey">(531cc6e)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: grey">(b0a61eb)</span></li>
<li>generators/kimgio/generator_kimgio.cpp <span style="color: grey">(1badab3)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-0.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-0mirror.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-180.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-180mirror.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-270.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-270mirror.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-90.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-90mirror.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-noexif.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/data/testExifOrientation-unspecified.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/tests/kimgiotest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>